The contrib modules used by the Guardr Core module should not be listed as dependencies in the main Guardr project.

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

shrop’s picture

This sounds like a good idea as long as we can accomplish two goals:

  1. Allow users to kickstart Guardr for a new project using the main distro project (Guardr) where Guardr Core is a dependency
  2. Allow users to easily include Guardr Core as a dependency of their projects (existing or new)

Seems this may possible work with those to goals, but needs to be tested.

I recommend a branch for this in Guardr and Guardr Core to test the setup.

Any other thoughts/concerns from the community?

joestewart’s picture

Status: Active » Needs review
StatusFileSize
new0 bytes

Patch attached. The patch will need to be updated with a release of guardr_core that has the dependencies defined.

joestewart’s picture

StatusFileSize
new10.32 KB

Patch attached. The patch will need to be updated with a release of guardr_core that has the dependencies defined.

joestewart’s picture

StatusFileSize
new13.09 KB

Patch rerolled.

Generated with "composer remove drupal/autologout drupal/diff drupal/hacked drupal/login_history drupal/login_security drupal/mass_pwreset drupal/password_policy drupal/r4032login drupal/seckit drupal/security_review drupal/session_limit drupal/username_enumeration_prevention"

Corresponding patch in guardr_core unaffected - https://www.drupal.org/project/guardr_core/issues/3008975#comment-12839318

damienmckenna’s picture

shrop’s picture

Planning to mark this fixed once #3072574: Remove files no longer needed in the Guardr project since the Github project handles D8 one-time installs is reviewed and committed, because the composer.json will be removed now that dependencies are managed in Guardr Core.

shrop’s picture

Status: Needs review » Fixed

Now that #3072574: Remove files no longer needed in the Guardr project since the Github project handles D8 one-time installs is completed we can mark this one fixed. Thanks for all the help everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.