In order to be used properly with Composer, all of the module dependencies need to be listed in a composer.json file.

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

Project: Guardr » Guardr Core
joestewart’s picture

Status: Active » Needs review
StatusFileSize
new1.09 KB

patch attached.

joestewart’s picture

Branch to use to test this patch - feature/3008975-composer-json
https://cgit.drupalcode.org/guardr_core/log/?h=feature/3008975-composer-...

joestewart’s picture

Status: Needs review » Needs work

It appears that the d.o. composer endpoint is providing this already.

These steps do install the dependencies:

composer create-project drupal-composer/drupal-project:8.x-dev guardr-project --stability dev --no-interaction
cd guardr-project/
composer require drupal/guardr_core

There are no version requirements yet though and appears to be missing:

hacked
mass_pwreset
security_review

#2998178: Update Format of Dependencies in .info File Also does not contain these modules.

Edit:

These indicate that a composer.json should be added:

https://www.drupal.org/node/2000204
https://www.drupal.org/docs/8/creating-custom-modules/add-a-composerjson...

joestewart’s picture

Status: Needs work » Needs review
joestewart’s picture

guardr patch removing these dependencies update - https://www.drupal.org/project/guardr/issues/3008977#comment-13024253

This patch is unaffected.

joestewart’s picture

Updated patch for #3044205: Use dev version of password_policy module using Password Policy 3.x dev version.

shrop’s picture

StatusFileSize
new512 bytes

Added new patch to lock Password Policy to a dev version commit. Confirmed all other projects in the composer.json file are updated and accurate. Need a quick check on this from the community and can commit.

joestewart’s picture

Status: Needs review » Reviewed & tested by the community

  • shrop committed 02c379f on feature/3008975-composer-json
    Issue #3008975 by joestewart, shrop: Add a composer.json for all of the...
shrop’s picture

Status: Reviewed & tested by the community » Fixed

  • shrop committed 02c379f on 8.x-1.x
    Issue #3008975 by joestewart, shrop: Add a composer.json for all of the...
shrop’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.