Update Drupal core to 8.6

Will this cover it?

I am using lando for local setup. I did the following:

• git clone https://git.drupal.org/project/guardr.git
• cd guardr
• git checkout 8.x-1.x
• curl https://www.drupal.org/files/issues/2018-09-06/guardr-n2997559-2.patch | patch -p1
• composer install
• cd web, lando init, lando start
• attempt to install via the ui and get missing modules notification (see attachment)

@DamienMcKenna: Thanks for the patch and @robpowell, thanks for testing. I will give it a go.

I am getting the same issue, but without the patch, so something else may be going on:

drush si --db-url=mysql://drupal:drupal@mariadb/drupal --account-name=admin --accou
nt-pass=admin --account-mail=admin@example.com --site-name=Guardr8 --site-mail=admin@example.com guardr
You are about to DROP all tables in your 'drupal' database. Do you want to continue? (y/n): y
Starting Drupal installation. This takes a while. Consider using the --notify global option.                       [ok]
Drupal\Core\Installer\Exception\InstallerException: Required modules: Required modules not found.               [error]

The following modules are required but were not found. Move them into the appropriate modules subdirectory,
such as <em>/modules</em>. Missing modules: <div class="item-list--comma-list item-list"><ul
class="item-list__comma-list"><li><span class="admin-missing">Drupal:node</span></li><li><span
class="admin-missing">Drupal:history</span></li><li><span
class="admin-missing">Drupal:block</span></li><li><span
class="admin-missing">Drupal:breakpoint</span></li><li><span
class="admin-missing">Drupal:ckeditor</span></li><li><span
class="admin-missing">Drupal:color</span></li><li><span
class="admin-missing">Drupal:config</span></li><li><span
class="admin-missing">Drupal:comment</span></li><li><span
class="admin-missing">Drupal:contextual</span></li><li><span
class="admin-missing">Drupal:contact</span></li><li><span
class="admin-missing">Drupal:menu_link_content</span></li><li><span
class="admin-missing">Drupal:datetime</span></li><li><span
class="admin-missing">Drupal:block_content</span></li><li><span
class="admin-missing">Drupal:quickedit</span></li><li><span
class="admin-missing">Drupal:editor</span></li><li><span
class="admin-missing">Drupal:help</span></li><li><span
class="admin-missing">Drupal:image</span></li><li><span
class="admin-missing">Drupal:menu_ui</span></li><li><span
class="admin-missing">Drupal:options</span></li><li><span
class="admin-missing">Drupal:path</span></li><li><span
class="admin-missing">Drupal:page_cache</span></li><li><span
class="admin-missing">Drupal:dynamic_page_cache</span></li><li><span
class="admin-missing">Drupal:taxonomy</span></li><li><span
class="admin-missing">Drupal:dblog</span></li><li><span
class="admin-missing">Drupal:search</span></li><li><span
class="admin-missing">Drupal:shortcut</span></li><li><span
class="admin-missing">Drupal:toolbar</span></li><li><span
class="admin-missing">Drupal:field_ui</span></li><li><span
class="admin-missing">Drupal:file</span></li><li><span class="admin-missing">Drupal:rdf</span></li><li><span
class="admin-missing">Drupal:views</span></li><li><span
class="admin-missing">Drupal:views_ui</span></li><li><span
class="admin-missing">Drupal:tour</span></li><li><span
class="admin-missing">Drupal:automated_cron</span></li><li><span
class="admin-missing">Drupal:ban</span></li><li><span
class="admin-missing">Drupal:update</span></li><li><span
class="admin-missing">Drupal:guardr_core</span></li></ul></div> in
/var/www/html/web/core/includes/install.core.inc:2203
Stack trace:
#0 /var/www/html/web/core/includes/install.core.inc(1033): install_display_requirements(Array, Array)
#1 /var/www/html/web/core/includes/install.core.inc(671): install_verify_requirements(Array)
#2 /var/www/html/web/core/includes/install.core.inc(549): install_run_task(Array, Array)
#3 /var/www/html/web/core/includes/install.core.inc(117): install_run_tasks(Array)
#4 /var/www/html/vendor/drush/drush/includes/drush.inc(727):
install_drupal(Object(Composer\Autoload\ClassLoader), Array)
#5 /var/www/html/vendor/drush/drush/includes/drush.inc(712): drush_call_user_func_array('install_drupal',
Array)
#6 /var/www/html/vendor/drush/drush/commands/core/drupal/site_install.inc(82): drush_op('install_drupal',
Object(Composer\Autoload\ClassLoader), Array)
#7 /var/www/html/vendor/drush/drush/commands/core/site_install.drush.inc(255):
drush_core_site_install_version('guardr', Array)
#8 /var/www/html/vendor/drush/drush/includes/command.inc(422): drush_core_site_install('guardr')
#9 /var/www/html/vendor/drush/drush/includes/command.inc(231): _drush_invoke_hooks(Array, Array)
#10 /var/www/html/vendor/drush/drush/includes/command.inc(199): drush_command('guardr')
#11 /var/www/html/vendor/drush/drush/lib/Drush/Boot/BaseBoot.php(67): drush_dispatch(Array)
#12 /var/www/html/vendor/drush/drush/includes/preflight.inc(66):
Drush\Boot\BaseBoot->bootstrap_and_dispatch()
#13 /var/www/html/vendor/drush/drush/drush.php(12): drush_main()
#14 {main}

The issue observed isn't a result of the patch. I created a bug to resolve so we can get back to this issue.

#2998363: Missing modules during install

This updates to 8.6.1.

I can't figure out how to test this patch, as the dependency is checked before patches are applied, so if I upgrade to Drupal 8.6, I can't reinstall guardr. Any suggestions on a workflow? Manually edit composer for the project and my composer lock?

I was able to use this patch and run a full 8.6 install end to end.

@oknate: Since Guardr is a starter distro, you can always test by following the info at https://www.drupal.org/project/guardr

Building Guardr for Drupal 8

    Clone the Guardr 8.x-1.x branch
    Change directory to the guardr directory
    Run composer install
    Install Drupal using the Guardr profile

I usually just clear my local db and delete vendor, core, composer.lock to help reset things. Does that help with testing questions?

Looks like we need Drupal 8.6.2 now. I have attached an updated patch with Drupal 8.6.2 core. I have also updated composer to user Guardr 1.x-dev to make builds and testing a bit easier in the dev branch until we roll a new alpha release. Then it will need to be updated to pull ~1.0.0 or similar again.

Feel free to test.

Committed an updated composer.json and composer.lock file for Drupal 8.6.2 after some testing. Thanks for everyone's help!