Hello,

When we enable only the Invite module and not it's submodules, Invite form is visible (../admin/structure/invite_type/add).
When no Invitation type module is enable, it should just display the message as we have in D7 module :
Message : Sorry no Invitation Type modules available in the system.

Comments

Dinesh18 created an issue. See original summary.

vj’s picture

Status: Active » Needs review

It does make sense to add this validation as without submodule invite module is not usable.

Added validation for the invite same as in D7.

vj’s picture

StatusFileSize
new1.09 KB
renatog’s picture

Checking

renatog’s picture

Status: Needs review » Needs work
StatusFileSize
new246.92 KB

I tested and have this error:

Can you check, please?

vj’s picture

@RenatoG
I have tested with clean Drupal installation and not thrown any error. Can you try by clearing cache or if any other module conflicting with it

renatog’s picture

Status: Needs work » Postponed (maintainer needs more info)

Hi Vj, I tested again and the error persists.

Just one confirmation; what version of core you're using?

You're using the the Drupal 8.06 ?

Thank you very much, Vj. Very good.

vj’s picture

I am using 8.7.x

renatog’s picture

Status: Postponed (maintainer needs more info) » Needs review

okay, I'll check in this version.

Thank you very much.

dwkitchen’s picture

Status: Needs review » Needs work
+++ b/src/Form/InviteTypeForm.php
@@ -73,6 +73,12 @@ class InviteTypeForm extends EntityForm {
+      drupal_set_message(t('Sorry no Invitation Type modules available in the system.'), 'error');

drupal_get_message() and drupal_set_message() replaced by Messenger service
https://www.drupal.org/node/2774931

saphemmy’s picture

Assigned: Unassigned » saphemmy
dale42’s picture

Assigned: saphemmy » Unassigned
StatusFileSize
new120.81 KB

Current status:

  • Code in InviteTypeForm.php has changed enough that patch does not apply
  • The code does have a message requesting a sending method module be enabled (see image)
  • The current code does not disable the submit button

Invite form screen shot

Add Invite type form screen shot

dale42’s picture

StatusFileSize
new131.93 KB
new1006 bytes

This patch:

  • Disables the submit button
  • Adds a warning message asking the user to enable a sending method

dale42’s picture

Status: Needs work » Needs review
renatog’s picture

Status: Needs review » Reviewed & tested by the community

#13 really makes sense. Thank you so much for your contribution @dale42

  • RenatoG committed 6fb2b65 on 8.x-1.x authored by dale42
    Issue #2997257 by dale42, Vj, RenatoG, Dinesh18, saphemmy, dwkitchen:...

  • RenatoG committed 78ab2f2 on 2.0.x authored by dale42
    Issue #2997257 by dale42, Vj, RenatoG, Dinesh18, saphemmy, dwkitchen:...
renatog’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x.-1.x and 2.0.x

Good catch @dale42 ! If you have more suggestions and patches, feel free to submit to us. Thanks a lot

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.