Problem/Motivation

When you have multiple mapping sources or mapping targets with the same label, there is no way to distinguish them.
Therefore it would be useful to display machine names of these sources/targets.

Example where you have a custom field labeled "Published". How to distinguish that from the status field?

Proposed resolution

One way of displaying the machine names is to add it between parentheses after the label of the source or target. I do think though it makes the UI look more bloated, so suggestions to display it otherwise are welcome.

CommentFileSizeAuthor
#8 Screenshot 2019-10-15 at 10.39.21 AM.png772.52 KBdinesh18
#7 feeds-machine-name-2996587-7.patch1.23 KBmegachriz
#5 after_patch.png2.04 MBdinesh18
#5 before_patch.png1.86 MBdinesh18
#2 feeds-machine-name-2996587-2.patch473 bytesmegachriz
targets-ui-after.png117.23 KBmegachriz
targets-ui-before.png91 KBmegachriz

Comments

MegaChriz created an issue. See original summary.

megachriz’s picture

megachriz
Primary language Dutch
commented
StatusFileSize
new feeds-machine-name-2996587-2.patch473 bytes

Work in progress patch implementing the solution posted in the issue summary. The solution is currently only implemented for targets, not for sources.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Active » Needs review
megachriz’s picture

megachriz
Primary language Dutch
commented
Related issues: +#1561200: Use machine names for better identification of similar field names

For the historical D7 issue, see #1561200: Use machine names for better identification of similar field names.

dinesh18’s picture

dinesh18 commented
StatusFileSize
new before_patch.png1.86 MB
new after_patch.png2.04 MB

I have reviewed the patch and it works perfectly fine. Here is the screenshot attached before and after patch.
+1 to RTBC

dinesh18’s picture

dinesh18 commented
Status: Needs review » Reviewed & tested by the community
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new feeds-machine-name-2996587-7.patch1.23 KB

This is a slightly different implementation. The machine names of the targets got shown in the legend as well, and there the machine names already got displayed.

Also made an other improvement on the way. Some targets don't have a description and in that case the label just ends with a colon. Removed that one. For example the node title target was displayed as "Title:". Now it will be displayed as "Title (title)".

dinesh18’s picture

dinesh18 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot 2019-10-15 at 10.39.21 AM.png772.52 KB

#7 patch is the improved patch and it looks better. Here is the screenshot attached after patch
+1 to RTBC

dinesh18’s picture

dinesh18 commented

  • MegaChriz committed 154caa5 on 8.x-3.x 
    Issue #2996587 by MegaChriz, Dinesh18: Display machine names of targets...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Reviewed & tested by the community » Fixed

@Dinesh18
Thanks for testing! Committed #7.

I think I leave out machine name support for sources (for now). These are displayed in the legend.

megachriz’s picture

megachriz
Primary language Dutch
commented
Title: Optionally display machine names of sources and targets on mapping » Display machine names of targets on mapping

Updating issue title to reflect better what is fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.