I've encountered the problem that $values['group'] is the string "JS_THEME"
That results in PHP 7.1 in the following warning:

Warning: A non-numeric value encountered in advagg_mod_js_move_to_footer() (line 2292 of \modules\contrib\advagg\advagg_mod\advagg_mod.module).

The following patch solved it for me.

CommentFileSizeAuthor
#4 non_numeric_value_encountered_advagg_mod_js_move_to_footer-2996430-4.patch730 bytesspokje

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new non_numeric_value_encountered_advagg_mod_js_move_to_footer-2996430-4.patch730 bytes

Patch against the latest 7.x-2-dev version.

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Status: Active » Needs review
yahyaalhamad’s picture

yahyaalhamad
Location Palestine
commented

It seems that this warning has been introduced in php 7.1. I guess it's happening because the code expects a number but gets a string instead. I will take a look.

Ahhh, wrong thread.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Looks good!

  • thalles committed 53b4a4c on 7.x-2.x authored by Spokje 
    Issue #2996430 by Spokje, thalles: Warning: A non-numeric value...
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.