Closed (duplicate)
Project:
Blazy PhotoSwipe
Version:
8.x-1.0-rc2
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
30 Aug 2018 at 17:56 UTC
Updated:
9 Sep 2018 at 09:19 UTC
Jump to comment: Most recent
Comments
Comment #2
gausarts commentedIt should work with VEF 8.1x. There is a change with VEF 8.2.x which removes what is needed.
The actual issue resides at Blazy module, not this module.
I haven't been able to correct this, but you may want to remove the function condition at blazy.module and blazy.views.inc:
https://cgit.drupalcode.org/blazy/tree/blazy.module#n84
https://cgit.drupalcode.org/blazy/tree/blazy.views.inc#n21
This function seems to be removed at 8.2.x:
if (function_exists('video_embed_media_media_bundle_insert')) {Or better change it to:
if (\Drupal::moduleHandler()->moduleExists('video_embed_media')) {Comment #3
heliogabalthanks for getting back for this so quickly and looking into it! VEF 8.2.x is needed for Media in Core, so no way around using that for me.
I tried your suggestion and changed the respective function conditions in the blazy module, but unfortunately, this seems not to be enough to make it work again.
But looking at the rendered HTML, I discovered something revealing... It seems there is an error in the JS that is calculating the padding-bottom on the element:
If I replace the value inline to the height of the preview-thumbnail, I'm actually seeing the video and can play it. Will have to look further into the JS so see if I'm able to solve this myself.
Comment #4
heliogabalon further inspection, I'm getting the following JS-Error that's also pointing to the problem calculating the size of the video object:
Uncaught ReferenceError: item is not defined at Function.a.theme.blazyPhotoSwipeMediaThis is the code the error is referring to in js/blazy.photoswipe.min.js:
and this is the corresponding function in js/blazy.photoswipe.js, line 233:
Now I have no idea why item is not defined, so I would hope someone with more JS knowledge could have a look at this and help me out.
Comment #5
geek-merlinLooked into that thing and it looks like a transient error... Will investigate further...
Comment #6
geek-merlinAfter doing the fix described in #2, the video does not show and some debugging shows that width and height are not passed.
As all this is coming from blazy.module, fixing the bug here needs some changes there.
So setting as dup of #2997224: Update to support Video Embed Field 8.2.x.