While evaluating this module I noticed that on the Extend page, the project name is in lower case and should be in title case to be consistent with the rest of the project names on the page.

"Capitalize the name of the module, because module names are proper nouns."

https://www.drupal.org/docs/develop/documenting-your-project/help-text-s...

Patch to follow, thanks!

CommentFileSizeAuthor
#3 ctools-capitalize-namespacing-2995908-3.patch1.36 KBvolkswagenchick
#2 ctools-capitalize-name-2995908-2.patch563 bytesvolkswagenchick

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Assigned: volkswagenchick » Unassigned
Status: Active » Needs review
StatusFileSize
new ctools-capitalize-name-2995908-2.patch563 bytes

I uploaded a patch that capitalizes the name of the module and also its submodules.
I also addressed a dependency namespacing issue:
According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.

https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...

Thanks!!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
StatusFileSize
new ctools-capitalize-namespacing-2995908-3.patch1.36 KB

Oooops - that patch was not complete. I have uploaded the correct one, thanks!

alonaoneill’s picture

alonaoneill commented
Status: Needs review » Reviewed & tested by the community

Reviewed the patch for spelling and grammar. Formatting aligns to Drupal documentation standards. Everything looks good. Patch applied.
Marking as RTBCed.
Thank you for working on module!

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

Thanks to you both, I agree, following the standard that others are written in core.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.