There are some CS issues.

CommentFileSizeAuthor
#5 realname-coding_standards-32995778-5.patch3.88 KBidebr
#5 interdiff-3-5.txt2.36 KBidebr
#3 2995778_realname_cs_fix_2.patch2.99 KBastonvictor
#2 2995778_realname_cs_fix.patch2.47 KBastonvictor

Comments

Aston Victor created an issue. See original summary.

astonvictor’s picture

astonvictor commented
Status: Active » Needs review
StatusFileSize
new 2995778_realname_cs_fix.patch2.47 KB
astonvictor’s picture

astonvictor commented
StatusFileSize
new 2995778_realname_cs_fix_2.patch2.99 KB

Status: Needs review » Needs work

The last submitted patch, 3: 2995778_realname_cs_fix_2.patch, failed testing. View results

idebr’s picture

idebr commented
Version: 8.x-1.0-rc1 » 8.x-1.x-dev
Status: Needs work » Needs review
StatusFileSize
new interdiff-3-5.txt2.36 KB
new realname-coding_standards-32995778-5.patch3.88 KB

This issue was partially fixed by #3013065: Add blank lines on RealnameRouteSubscriber and #3015550: Use full namespace on @param in realname.module. This should fix the remaining issues.

  • hass committed 1806577 on 8.x-1.x authored by idebr 
    Issue #2995778 by Aston Victor, idebr: Coding standard
hass’s picture

hass commented
Status: Needs review » Fixed

I'm not committing the other changes as this makes no sense to me.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.