According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.

https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new1.13 KB

I uploaded a patch that corrects the dependency namespacing in the .info.yml file.
Thanks!

volkswagenchick’s picture

Status: Needs review » Reviewed & tested by the community

Code looks good. Patch applied via simplytest.me. I compared file to core modules and the dependency namespacing issue has been addressed.

Marking RTBC

rajab natshah’s picture

Status: Reviewed & tested by the community » Needs work
rajab natshah’s picture

StatusFileSize
new11.06 KB

Updated the patch file.

rajab natshah’s picture

Title: Dependency namespacing in .info.yml file » Changed [Varbase Core] module info.yml to project:module syntax standard not to have a broken installation of sub profiles

  • RajabNatshah committed 81024ec on 8.x-6.x
    Issue #2995713: Changed [Varbase Core] module info.yml to project:module...
rajab natshah’s picture

rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned

  • RajabNatshah committed c0efeda on 8.x-6.x
    Issue #2995713: Changed [Varbase Core] module info.yml to project:module...

  • RajabNatshah committed eeddb0e on 8.x-6.x
    Issue #2995713: Changed the patch for which to allow profiles to provide...

  • RajabNatshah committed 9bc8560 on 8.x-5.x
    Issue #2995713: Changed [Varbase Core] module info.yml to project:module...
rajab natshah’s picture

Issue tags: +varbase-8.5.2, +varbase-8.6.0

  • RajabNatshah committed edee5ff on 8.x-6.x
    Issue #2995713: Changed [Varbase Core] module info.yml to project:module...

  • RajabNatshah committed 528d53d on 8.x-5.x
    Issue #2995713: Changed [Varbase Core] module info.yml to project:module...
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Version: 8.x-6.x-dev » 8.x-5.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.