[regression] Check first if views data exists in datetime_range module

I had a failing test for this too, same line but different field.

In my case the test view referenced a field that didn't exist in the test.

Can you check you view's yaml to see if it is in same boat?

In my case, creating the field in the test setup resolved it.

@claudiu.cristea any chance that something similar to your alter hook could be added to a to a test module so we could have test coverage to prevent future regressions?

This looks great to me! Just one small issue with the test:

+++ b/core/modules/datetime_range/tests/src/Kernel/Views/EntityTypeWithoutViewsDataTest.php
@@ -0,0 +1,43 @@
+    $view_yaml = drupal_get_path('module', 'taxonomy') . '/' . InstallStorage::CONFIG_OPTIONAL_DIRECTORY . '/views.view.taxonomy_term.yml';
+    $values = Yaml::decode(file_get_contents($view_yaml));
+    View::create($values)->save();

This reliably reproduces the issue, but IIRC, all tests should have at least one assertion or they will cause issues with the beStrictAboutTestsThatDoNotTestAnything we specify in phpunit.xml.dist (oddly this is set to true, but I think the run-tests.sh script ignores it).

So perhaps simply asserting the return value of the save call or something?

Thanks for the fix and the test!

+++ b/core/modules/datetime_range/datetime_range.module
@@ -52,10 +52,10 @@ function datetime_range_view_presave(ViewEntityInterface $view) {
-        if ($filter['plugin_id'] === 'string') {
+        if ($filter['plugin_id'] === 'string' && $table_data = Views::viewsData()->get($filter['table'])) {
 
           // Get field config.
-          $filter_views_data = Views::viewsData()->get($filter['table'])[$filter['field']]['filter'];
+          $filter_views_data = $table_data[$filter['field']]['filter'];
           if (!isset($filter_views_data['entity_type']) || !isset($filter_views_data['field_name'])) {
             continue;
           }

@@ -127,10 +127,10 @@ function datetime_range_view_presave(ViewEntityInterface $view) {
-        if ($sort['plugin_id'] === 'standard') {
+        if ($sort['plugin_id'] === 'standard' && $table_data = Views::viewsData()->get($sort['table'])) {
 
           // Get field config.
-          $sort_views_data = Views::viewsData()->get($sort['table'])[$sort['field']]['sort'];
+          $sort_views_data = $table_data[$sort['field']]['sort'];
           if (!isset($sort_views_data['entity_type']) || !isset($sort_views_data['field_name'])) {
             continue;
           }

I think we should avoid the assignment in the condition. Let's do a continue instead so something like...

$table_data = Views::viewsData()->get($filter['table']);
if (!$table_data) {
  continue;
}

+++ b/core/modules/datetime_range/tests/src/Kernel/Views/EntityTypeWithoutViewsDataTest.php
@@ -0,0 +1,43 @@
+  public function test() {

test methods usually have a more descriptive name.

Works, with tests and comments addressed.

Committed and pushed 687c6ec32d to 8.7.x and a7983d5146 to 8.6.x. Thanks!