Hi,

I have noticed that, private message unread count is showing wrongly. It is showing based on the thread id which is update after last access. But I unread message count should come only for the "to" user not for "from" member.

I have create based on thread owner.

Please review!

CommentFileSizeAuthor
#6 Capture d’écran du 2019 01 30 11 58 00.png214.98 KBzenimagine
#6 Capture d’écran du 2019 01 30 11 55 42.png455.63 KBzenimagine
#4 unread_message_count-2995327-4.patch1.81 KBcosolom
#2 unread_message_count-2995327-2.patch1.81 KBsaranya ashokkumar

Comments

saranya purushothaman created an issue. See original summary.

saranya ashokkumar’s picture

saranya ashokkumar commented
Status: Active » Needs review
StatusFileSize
new unread_message_count-2995327-2.patch1.81 KB
nagarajan kumar’s picture

nagarajan kumar commented
Status: Needs review » Reviewed & tested by the community

the above patch working fine .now showing exact count.

cosolom’s picture

cosolom commented
StatusFileSize
new unread_message_count-2995327-4.patch1.81 KB

Fixed: DESC it's not constant and replaced double quotes to single quotes (code standard)

zenimagine’s picture

zenimagine commented

Super, thanks the patch #4 corrects the problem for me.

Is this question related to https://www.drupal.org/project/private_message/issues/2977310 ?

zenimagine’s picture

zenimagine commented
StatusFileSize
new Capture d’écran du 2019 01 30 11 55 42.png455.63 KB
new Capture d’écran du 2019 01 30 11 58 00.png214.98 KB

@cosolom Before applying the patch, when I send a message it was counted as unread. Now it works but there are still 2 bugs:

- When I send a message it is well understood as read in the notification block. But in my Inbox Views, it is counted as unread.

- If I am on the conversation and receive a message, the notification block counts it as unread. Yet I'm on the conversation, it does not make sense.

mike82’s picture

mike82 commented
Related issues: +#2984799: Unread Thread Count not updated correctly, +#2977310: Own send messages are shown as new messages

I think this issue is better solved here Own send messages are shown as new messages.
In my opinion it is much faster to solve it in sql query instead of using foreach. Also the aforementioned issue fixes 2 more issues.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented

The SQL query has been merged, so is this issue remains? I have not seen any bugs so far with the new change, so I think it can be closed.

anmolgoyal74’s picture

anmolgoyal74 commented
Status: Reviewed & tested by the community » Fixed

Marking as Fixed.
If anyone still faces this issue, feel free to open this again.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.