Problem/Motivation

We want to support includes when serializing an entity into JSON API format.

Proposed resolution

Alter the service to take the information for the includes query string parameter.

CommentFileSizeAuthor
#10 2995142--interdiff--8-9.txt7.91 KBe0ipso
#9 2992557--add-includes-support--11.patch9.99 KBe0ipso
#8 interdiff-2995142-7-8.txt441 bytesbr0ken
#8 2995142-8.patch9.7 KBbr0ken
#7 interdiff-2995142-5-7.txt520 bytesbr0ken
#7 2995142-7.patch9.36 KBbr0ken
#5 interdiff-2995142-3-5.txt5.4 KBbr0ken
#5 2995142-5.patch8.76 KBbr0ken
#3 interdiff-2995142-2-3.txt469 bytesbr0ken
#3 2995142-3.patch3.26 KBbr0ken
#2 2995142-2.patch3.26 KBbr0ken

Comments

e0ipso created an issue. See original summary.

br0ken’s picture

br0ken
Primary language Ukrainian
commented
Status: Active » Needs review
StatusFileSize
new 2995142-2.patch3.26 KB
br0ken’s picture

br0ken
Primary language Ukrainian
commented
StatusFileSize
new 2995142-3.patch3.26 KB
new interdiff-2995142-2-3.txt469 bytes

[Copy-paste detected]

The last submitted patch, 2: 2995142-2.patch, failed testing. View results

br0ken’s picture

br0ken
Primary language Ukrainian
commented
StatusFileSize
new 2995142-5.patch8.76 KB
new interdiff-2995142-3-5.txt5.4 KB

Status: Needs review » Needs work

The last submitted patch, 5: 2995142-5.patch, failed testing. View results

br0ken’s picture

br0ken
Primary language Ukrainian
commented
Status: Needs work » Needs review
StatusFileSize
new 2995142-7.patch9.36 KB
new interdiff-2995142-5-7.txt520 bytes

The BootstrapConfigStorageFactory::get()->read('jsonapi_extras.settings') may be false and that leaads to the / as a value of the jsonapi.base_path container parameter.

br0ken’s picture

br0ken
Primary language Ukrainian
commented
StatusFileSize
new 2995142-8.patch9.7 KB
new interdiff-2995142-7-8.txt441 bytes

Assert that base path is longer than one symbol (slash).

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
StatusFileSize
new 2992557--add-includes-support--11.patch9.99 KB

I made some changes to the patch on #8.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
StatusFileSize
new 2995142--interdiff--8-9.txt7.91 KB

  • e0ipso committed 41813c2 on 8.x-2.x authored by BR0kEN 
    Issue #2995142 by BR0kEN, e0ipso: Support includes the EntityToJsonapi...
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.