Problem/Motivation

While using layout builder, clicking "Add Section" opens the off-canvas dialog that has a title "Choose a layout" at the top.
off-canvas dialog with title

While using layout builder, clicking "Add Block" opens the off-canvas dialog without a title at the top.
off-canvas dialog without title

Proposed resolution

Add a title to the top of the off-canvas dialog. Proposed text: "Choose a block"

Remaining tasks

N/A

User interface changes

New title added.

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#3 2995078-choose-block-title-3.patch1.23 KBsugaroverflow
Screen Shot 2018-08-25 at 3.01.32 PM.png104.54 KBdead_arm
Screen Shot 2018-08-25 at 3.01.20 PM.png45.43 KBdead_arm

Comments

dead_arm created an issue. See original summary.

sugaroverflow’s picture

sugaroverflow commented
Assigned: Unassigned » sugaroverflow
sugaroverflow’s picture

sugaroverflow commented
Status: Active » Needs review
StatusFileSize
new 2995078-choose-block-title-3.patch1.23 KB

Added "Choose a block" as a title to the dialog.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

Thanks for this! There is still #2929783: Review Layout Builder UI terminology to review any more changes needed, but it's good to get some text in there in the first place!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: sugaroverflow » Unassigned

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2995078-choose-block-title-3.patch, failed testing. View results

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Closed (duplicate)

"CI job missing"

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Closed (duplicate) » Reviewed & tested by the community

oops

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2995078-choose-block-title-3.patch, failed testing. View results

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Needs work » Reviewed & tested by the community

  • lauriii committed 9ee0227 on 8.7.x 
    Issue #2995078 by sugaroverflow, dead_arm: Add a title to the off-canvas...

  • lauriii committed ac3a278 on 8.6.x 
    Issue #2995078 by sugaroverflow, dead_arm: Add a title to the off-canvas...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed 9ee0227 and pushed to 8.7.x. Also cherry-picked to 8.6.x. Thanks! ✨

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: +Blocks-Layouts

Retroactively tagging