Problem/Motivation

ContentHub 8.x-1.x doesn't work with the upcoming release of Drupal 8.6 because Normalizers have been made private and ContentHub calls its normalizer service directly in many places.

Proposed resolution

Rather than refactor the entire 1.x code base to conform to Drupal 8.6's new requirements, we should introduce a new service that proxies to our normalizer, mark it as the normalizer in the services yml and keep our existing service under the same name but simply no longer consider it a "normalizer" in Drupal's terminology. This allows us to NOT break existing code that might be relying on the service directly but still allows us to proxy to the code in that service from the class that Drupal considers to be the actual normalizer.

Remaining tasks

Test it.

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 2994723-2.patch6.78 KBeclipsegc

Comments

EclipseGc created an issue. See original summary.

eclipsegc’s picture

Status: Active » Needs review
StatusFileSize
new6.78 KB

Jakob and I worked to product a patch for this problem. We'll need some people to give it a test and let us know if it solves their problems.

Eclipse

damontgomery’s picture

Status: Needs review » Reviewed & tested by the community

Before this patch, we were using Drupal core 8.6 beta and were not able to publish content to Content Hub. After this patch, we could publish content to Content Hub.

I tested this on a local machine with the credentials for our dev site and made the site available to Acquia with ngrok. I published a custom block and saw it show up in the Acquia Lift Chrome extension.

I also created a custom text block with a Lift embed code, created a Lift slot, and added that content to the slot. The content matched the published display.

I'm marking this as `Reviewed & tested by the community` and feel like it could be merged.

Thanks!

japerry’s picture

Status: Reviewed & tested by the community » Fixed

tests are passing, getting it in for the release! Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.