The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.When you
- create a tip and assign a class or an ID.
- If you try to edit and assign modal, the change doesn't gets saved to the database.
- If you go back to edit the tip you will see that it is still assigned to a class or ID.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | tour_ui-2994408-5.patch | 779 bytes | clemens.tolboom |
Comments
Comment #2
clemens.tolboomThis is also a bug in #3003288: Cannot edit tour tip
Comment #3
clemens.tolboomDebugging this the form is build OK
- modules/tour_ui/src/Form/TourTipForm.php:56
The code when submitting does not get the correct values for the ATTRIBUTES section
- modules/tour_ui/src/Form/TourTipForm.php:147
Is this because we 'are' a TipPluginTextExtended
Or is the logic in \Drupal\tour_ui\Plugin\tour_ui\tip\TipPluginTextExtended::buildConfigurationForm wrong?
Comment #4
clemens.tolboomThe form submit should check for the Selector type value then unset the appropriate attributes to match with the logic in \Drupal\tour_ui\Plugin\tour_ui\tip\TipPluginTextExtended::buildConfigurationForm I guess now.
Comment #5
clemens.tolboomAttached patch seems to solve this bug.
- The core/modules/tour/config/schema/tour.schema.yml has for tip a list of attributes; aka not particular keys.
- Test core/modules/tour/tests/tour_test/config/install/tour.tour.tour-test.yml has tips using either with no attribute, data-id or data-class.
I'm inclined to submit this fix asap but for the record and WTF is going on this patch. (I have to adjust some comment now I've written this comment)
Comment #7
clemens.tolboomComment #8
clemens.tolboomComment #9
clemens.tolboom