Currently core allows the installation of "paragonie/random_compat" with the following constraints: "^1.0|^2.0".
If these get updated to "^1.0|^2.0|^9.99.99", then the NOOP version would be installable as well.

This NOOP version is only installable on php 7.0+ and does not populate the autoloader like other versions. Which provides a microscopic performance gain.

CommentFileSizeAuthor
#12 2994315-12.patch482 bytesalexpott
#8 version-constraint.patch464 bytesBackEndTea
#2 paragonie.patch444 bytesBackEndTea

Comments

BackEndTea created an issue. See original summary.

BackEndTea’s picture

BackEndTea commented
StatusFileSize
new paragonie.patch444 bytes
BackEndTea’s picture

BackEndTea commented
Issue summary: View changes
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

https://github.com/paragonie/random_compat/ suggests using ">=1" as the version constraint.

However, is this even worth changing, as this package will presumably be removed in 8.7.x or 8.8.x when we drop PHP 5 support?

BackEndTea’s picture

BackEndTea commented

This version constraint is more in line with how other version constraints are handled. It would also allow the decision of a possible 3.* version to be made at that point.

8.7 and 8.8 are still a bit away, and the update has no negative impact on the upgrade to 8.7/8.8

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: paragonie.patch, failed testing. View results

BackEndTea’s picture

BackEndTea commented
StatusFileSize
new version-constraint.patch464 bytes

I have added the correct patch

BackEndTea’s picture

BackEndTea commented
Status: Needs work » Needs review

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

amateescu’s picture

amateescu commented
Version: 8.6.x-dev » 8.7.x-dev
Status: Needs review » Reviewed & tested by the community

Looks good to me. Note that we're removing paragonie/random_compat for 8.8.x in #3058116: Remove paragonie/random_compat as a top-level dependency from 8.8.x, so this is only a 8.7.x patch.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2994315-12.patch482 bytes

rerolled the patch

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed db53fd7 and pushed to 8.7.x. Thanks!

  • alexpott committed db53fd7 on 8.7.x 
    Issue #2994315 by BackEndTea: Allow installation of latest paragonie/...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.