The date_recur field should work the same as a date_range field when no RRULE is provided.

  • Add tests and ensure non RRULE works.
  • If a field doesnt contain a RRULE, the same basic API's for getting occurrences should work correctly. That is, one fake occurrence should be created.
CommentFileSizeAuthor
#12 2993554-12.patch706 bytesjoelpittet
#6 2993554-non-recurring-occurrences-6.patch14.71 KBdpi
#5 2993554-non-recurring-occurrences-5.patch13.4 KBdpi
#4 2993554-non-recurring-occurrences-4.patch13.46 KBdpi
#3 2993554-non-recurring-occurrences.patch13.46 KBdpi
#2 2993554-non-recurring-occurrences.patch13.54 KBdpi

Comments

dpi created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Active » Needs review
StatusFileSize
new 2993554-non-recurring-occurrences.patch13.54 KB
dpi’s picture

dpi
Location Perth, Australia
commented
StatusFileSize
new 2993554-non-recurring-occurrences.patch13.46 KB
dpi’s picture

dpi
Location Perth, Australia
commented
StatusFileSize
new 2993554-non-recurring-occurrences-4.patch13.46 KB
dpi’s picture

dpi
Location Perth, Australia
commented
StatusFileSize
new 2993554-non-recurring-occurrences-5.patch13.4 KB
dpi’s picture

dpi
Location Perth, Australia
commented
StatusFileSize
new 2993554-non-recurring-occurrences-6.patch14.71 KB

  • dpi committed d576364 on 8.x-2.x 
    Issue #2993554: Non recurring date values must generate occurrences.

  • dpi committed 7f2e737 on 8.x-2.x 
    Issue #2993554: Clean up cache storage occurrence helper.

Thanks to new...
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Needs work

I'm liking the look of this clean up. Question about this bit of code:

+++ b/src/DateRecurNonRecurringHelper.php
@@ -0,0 +1,102 @@
+      yield $occurrence;

What is yield ?

Couldn't find it in php.net/yield

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review

Strange that didn't find it but I guess it has to be a function, learned something new:)
http://php.net/manual/en/language.generators.syntax.php

dpi’s picture

dpi
Location Perth, Australia
commented

Generators are a lot of fun.

Basically PHP will keep a function around in memory similar to a process. If you iterate over the function new values are generated. The function will pause (like a process) if/until the next iteration happens.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new 2993554-12.patch706 bytes

Not sure if you want a new issue for this but here's a quick patch for a missing isRecurring() call.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Also, re generators. I wonder what the performance implications are of keeping them in memory are, have you profiled them before?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

They look pretty much the same in my super poor profile:)
https://3v4l.org/KJMt3/perf#output
https://3v4l.org/BskcY/perf#output

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs review » Fixed

#12 no longer relevant as the method was removed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.