Closed (fixed)
Project:
Search API
Version:
8.x-1.x-dev
Component:
Views integration
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Aug 2018 at 20:21 UTC
Updated:
5 Oct 2018 at 08:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jasonawantI will work on a patch.
Comment #3
jasonawantHere's a patch to manage multiple arguments passed as 1+2+3 (for OR) or 1,2,3 (for AND) include the negate option. Feedback welcome. Tests are probably needed, and I can work on them with some guidance. Thanks, Jason
Comment #4
drunken monkeyThanks for reporting this and already providing a patch!
Weird, though – I could’ve sworn we were already doing that … Maybe it was just in D7, and we forgot to port it?
Anyways, your patch looks great, just a single matter of personal taste:
I personally don’t like Yoda conditions, so please don’t use them here.
Otherwise, the patch looks perfect already – thanks again!
You’re right, though, we should have test coverage for this. But it should be just a line – see the attached patch.
Comment #5
jasonawantHi,
Thanks for the feedback and test coverage. New patch works as expected, Jason
Comment #7
drunken monkeyThanks for reporting back, good to hear!
Committed.
Thanks again!
Comment #8
drilauri commentedWill this be fixed in 7 as well? I receive "Notice: Undefined index: break_phrase in SearchApiViewsHandlerArgument->options_form() (line 96 of .../modules/search_api/contrib/search_api_views/includes/handler_argument.inc)" when editing a More like this view after updating to Search API 7.x-1.25.
Comment #9
drunken monkeyThat’s a completely different problem. Please see #3001424: More Like This contextual filter doesn’t handle parent options correctly.