see https://www.drupal.org/project/drupal/issues/2677990 a new key was added and the test needs to be updated

 $this->assertIdentical(array_keys($conf_form), array('description'));

test fail

CommentFileSizeAuthor
#7 entity-embed-update-test-2993391-7.patch780 bytesoknate
#6 entity-embed-update-test-2993391-6.patch781 bytesoknate
#3 Screen Shot 2018-08-17 at 11.56.59 AM.png154.25 KBoknate
#2 entity-embed-update-test-2993391-2.patch818 bytesoknate

Comments

oknate created an issue. See original summary.

oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new entity-embed-update-test-2993391-2.patch818 bytes
oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new Screen Shot 2018-08-17 at 11.56.59 AM.png154.25 KB
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented

Hmm, that didn't work:

Fail: [Other] Line 65 of modules/contrib/entity_embed/src/Tests/FileFieldFormatterTest.php:
Value array (
  0 => 'description',
) is identical to value array (
  0 => 'use_description_as_link_text',
  1 => 'description',
).

Now it's just description.

oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new entity-embed-update-test-2993391-6.patch781 bytes

Looking more closely, it's looking at a form and just needs to verify that the description key is there in the form.

oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new entity-embed-update-test-2993391-7.patch780 bytes
oknate’s picture

oknate
Location Greater New York City Area
commented
Status: Active » Needs review

OK, the last patch (#7) fixes this one assertion.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

LGTM! Thanks! 🙏

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Priority: Minor » Critical

This should land first, and ASAP.

Wim Leers credited phenaproxima.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

@phenaproxima went ahead and committed this! 🎉

Thanks!

oknate’s picture

oknate
Location Greater New York City Area
commented

Awesome, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.