Thank you for this module.

I think using option fields for custom markers would be beneficial. Please find attached a plugin that enables option fields for enabling this. No rocket science as this is merely an adaptation from the taxonomy and bundle plugins.
I'm not sure if it needs tests but anyway I'm not very capable of writing them ;-). It sure needs testing though since it's hard to foresee every possible use case. It should work for all "list" field types (list_string, list_integer, list_float).

Kind regards,
Eric

CommentFileSizeAuthor
#4 listfieldthemer_2993361_4.patch15.1 KBitamair
optionfieldthemer.diff13.98 KBsolide-echt

Comments

solide-echt created an issue. See original summary.

itamair’s picture

itamair commented

tnx @solide-echt ... sounds nice.
Will carefully and deeply review this asap

itamair’s picture

itamair commented
Title: Custom marker for option fields » Custom marker for List type fields
Status: Needs review » Needs work
itamair’s picture

itamair commented
StatusFileSize
new listfieldthemer_2993361_4.patch15.1 KB

tnx @solide-echt for this input ... but your original patch MapThemer plugin was incomplete and buggy.

For sake of coherence with Drupal field type naming I changed its id and class name definitions, made it more complete and tested,
in this new attached updated patch, and also committed it to dev.

I will commit all this into the next release, after updating also the relevant module documentation.
In this meanwhile all possible further testing and reviewing would be really welcome.

  • itamair committed bd6c0a4 on 8.x-2.x 
    Issue #2993361 by itamair, solide-echt: Custom marker for List type...
itamair’s picture

itamair commented
Status: Needs work » Needs review

  • itamair committed 6e3fe35 on 8.x-2.x 
    Issue #2993361 by itamair, solide-echt: Implementation of List Type...
itamair’s picture

itamair commented
Status: Needs review » Fixed
solide-echt’s picture

solide-echt commented

Thnx for your quick feedback!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.