Can we implement allowfullscreen attribute in the iframe module. This attribute is needed if you want to set the frame fullscreen.

allowfullscreen
This attribute can be set to true if the frame is allowed to be placed into full screen mode by calling its requestFullscreen() method. If this isn't set, the element can't be placed into full screen mode.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#Attributes

Comments

fdverwoerd created an issue. See original summary.

dries arnolds’s picture

dries arnolds
Primary language Dutch
Location 🇳🇱 Amsterdam
commented

This is something I really need as well.

joonapenttila’s picture

joonapenttila commented

Yeah I need this too for D8 :s

  • dd399cc committed on 7.x-1.x 
    Issue #2992967: Allow fullscreen attribute for iFrame
neffets’s picture

neffets commented
Assigned: Unassigned » neffets
Category: Feature request » Task

we will add it as attribute allow="fullscreen"

  • a97e477 committed on 8.x-1.x 
    Issue #2992967: Allow fullscreen attribute for iFrame

  • 65d6944 committed on 8.x-1.x 
    Issue #2992967: Allow fullscreen attribute for iFrame
redeight’s picture

redeight commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Priority: Normal » Major
Status: Active » Needs work

Reopening this as these changes horribly break any install on D8 earlier than 8.x-1.10.
There is no hook_update to add the requisite schema columns to the table so anyone updating to 8.x-1.10 (and now 8.x-1.11) ends up with a broken iFrame. Currently, manually editing the database table to add the column or rolling back to 8.x-1.9 are the only fixes.

neffets’s picture

neffets commented
Status: Needs work » Fixed
Related issues: +#3091781: SQLstate column not found error after updating

field now working with bugfix in #3091781

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.