oa_core_get_group_from_node() references the variable $node_type where $allowed_types was meant. This prevents an optimization when $node->type is in $allowed_types.
I think in many large Drupal websites the entitycache module is installed. Quite a lot of utility functions in oa_core assume that node_load() is slow and access the database directly, while it might actually be faster to call node_load() when entitycache is enabled.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 2992760-oa_core-fix-shortcut-6.patch | 1.54 KB | Jorrit |
| #2 | 2992760-oa_core-entitycache-2.patch | 3.25 KB | Jorrit |
Comments
Comment #2
Jorrit commentedPlease see the attached patch.
Comment #3
mpotter commentedI'm always nervous about messing with caching at this point given that I have so little time to test or support Atrium. There was a time when entitycache didn't work well with Atrium. So yes, there was a lot of work done on Atrium performance to improve it without needing entitycache. I'd need to see some benchmarks and testing from more people before making caching changes.
Comment #4
Jorrit commentedI understand the difficulty in reviewing the more complicated patches that I submit. Perhaps you could commit just the first bit, which is a small bugfix and wait for the larger, entitycache related, piece until more testing has been done?
Anyway, thanks for your time in reviewing and committing the patches that I submitted.
Comment #5
mpotter commentedSure, could you submit a smaller patch? In the middle of getting a release ready for the Panopoly update yesterday so any help would be appreciated!
Comment #6
Jorrit commentedHere you go. I didn't test it because I am working on a different computer now but these are the changes from the original patch that seem safe to me.
Comment #7
mpotter commentedOK, that definitely fixes a bug, so committed to 01211f7. To keep this patch issue clean, do you want to create a new issue for the entitycache patch and then close this as Fixed?
Comment #8
Jorrit commentedI will do that next week.
Comment #9
Jorrit commentedI created #3006977: Optimize oa_core_get_group_from_node() when entitycache is present as a follow-up issue.