While evaluating this module, I noticed it lacked a readme.
According to Drupal standards, modules should include a useful README.file.
https://www.drupal.org/docs/develop/documenting-your-project/module-docu....

https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...

Patch to follow, thanks!

CommentFileSizeAuthor
#4 interdiff-2992434-2-4.txt246 bytesvolkswagenchick
#4 lock_field_values-README-2992434-4.patch1.55 KBvolkswagenchick
#2 lock_field_values-readme-2992434-2.patch1.57 KBvolkswagenchick

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Assigned: volkswagenchick » Unassigned
Status: Active » Needs review
StatusFileSize
new lock_field_values-readme-2992434-2.patch1.57 KB

I uploaded a file that contains a README as per Drupal documentation standards, thanks!

alonaoneill’s picture

alonaoneill commented
Status: Needs review » Needs work

Reviewed the patch for spelling and grammar. Formatting aligns to Drupal documentation standards. Everything looks good, but I did find a mistake

+++ b/README.md
@@ -0,0 +1,57 @@
+ * Recommended Modules

This line can be removed, since there is no Recommended Modules.
Marking as Need work.
Thank you for working on module!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs work » Needs review
StatusFileSize
new lock_field_values-README-2992434-4.patch1.55 KB
new interdiff-2992434-2-4.txt246 bytes

Thanks for the review. I have uploaded a patch that removes the "Recommended modules" form the table of contents. I also uploaded an interdiff for easy review.

alonaoneill’s picture

alonaoneill commented
Status: Needs review » Reviewed & tested by the community

Everything looks good, patch applied!
Marking as RTBCed
Thank you for working on module!

daggerhart’s picture

daggerhart commented
Status: Reviewed & tested by the community » Fixed

This is great, thanks! Committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.