So it turns out that because Tome runs on the command line, the core/dynamic page cache doesn't work. This is explicit in Drupal\Core\PageCache\DefaultRequestPolicy and Drupal\dynamic_page_cache\PageCache\RequestPolicy\DefaultRequestPolicy. This stinks!

We'll need to decorate these service and change the default policies to allow CLI page requests to be cached.

CommentFileSizeAuthor
#2 2992119-2.patch3.77 KBsamuel.mortenson

Comments

samuel.mortenson created an issue. See original summary.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 2992119-2.patch3.77 KB

Here's a patch. Working on performance metrics now.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented

Tested with 100 nodes with unique images, and a paged view (20 extra pages). Also warm cache on all runs.

Without patch:
Dynamic page cache: ~37s
Core page cache: ~37s

With patch:
Dynamic page cache: ~23s
Core page cache: ~23s

Not a bad performance boost!

  • samuel.mortenson authored 66af419 on 8.x-1.x 
    Issue #2992119 by samuel.mortenson: Tome doesn't use any page caching
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +D8 cacheability, +Performance

Nice! :D