The EntityResource class has a few methods that have unused variables that exist because it was too complex to figure out which methods needed which arguments in the RequestHandler. Since we can rely on the routers arguments resolver to do this now (that is, after #2987610: Remove RequestHandler class and service and add EntityResource methods to each route definition lands) we can clean those up.

Comments

gabesullice created an issue. See original summary.

gabesullice’s picture

StatusFileSize
new2.55 KB

This gets this started.

gabesullice’s picture

Status: Active » Postponed
wim leers’s picture

Title: [PP-1] Remove unused parameters from EntityResource methods. » Remove unused parameters from EntityResource methods.
Status: Postponed » Needs work
gabesullice’s picture

Assigned: gabesullice » Unassigned
Status: Needs work » Needs review
StatusFileSize
new1.77 KB

Easy enough!

Status: Needs review » Needs work

The last submitted patch, 6: 2991841-6.patch, failed testing. View results

gabesullice’s picture

Status: Needs work » Needs review
StatusFileSize
new1.4 KB
new3.17 KB

Whoops. Simple fix.

Status: Needs review » Needs work

The last submitted patch, 8: 2991841-8.patch, failed testing. View results

wim leers’s picture

There's more apparently.

gabesullice’s picture

Status: Needs work » Needs review
StatusFileSize
new816 bytes
new3.17 KB

Bah!

wim leers’s picture

StatusFileSize
new925 bytes
new3.71 KB

I really want Gabe to be able to mentally classify this one as "DONE ✔️✅ 🏁". So … rerolling on his behalf :P

HAHAHAHA JUST AS HE DECIDES TO DO IT, I DID TOO 😂

The last submitted patch, , failed testing. View results

gabesullice’s picture

Status: Needs review » Reviewed & tested by the community

/me tableflips

I didn't include the interdiff in #10 I guess. @Wim Leers's #12 is what should have been.

The last submitted patch, 2: 2991841-2.patch, failed testing. View results

  • Wim Leers committed f05058a on 8.x-2.x authored by gabesullice
    Issue #2991841 by gabesullice, Wim Leers: Remove unused parameters from...
wim leers’s picture

Status: Reviewed & tested by the community » Fixed

'T is done!

gabesullice’s picture

🛳🛳🛳🛳🛳🛳🛳🛳🛳🛳🛳🛳

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.