Notice: Undefined index: reset_date in Drupal\agreement\Entity\Agreement->getAgreementFrequencyTimestamp() (line 85 of modules/contrib/agreement/src/Entity/Agreement.php).
Drupal\agreement\Entity\Agreement->getAgreementFrequencyTimestamp() (Line: 109)
Drupal\agreement\AgreementHandler->hasAgreed(Object, Object) (Line: 136)
Drupal\agreement\Form\AgreementForm->buildForm(Array, Object, Object)
call_user_func_array(Array, Array) (Line: 518)
Drupal\Core\Form\FormBuilder->retrieveForm('agreement_default_form', Object) (Line: 275)
Drupal\Core\Form\FormBuilder->buildForm('agreement_default_form', Object) (Line: 74)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 582)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 666)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
Comments
Comment #2
branana commentedComment #3
mradcliffeThanks for the patch. I haven't had a chance to review it yet.
Flipping to Needs review for test bot.
Comment #4
mradcliffeI decided to look at the root cause, which is that getSettings should probably be merging in defaults rather than returning defaults or whatever is stored in settings.
Here's a patch that should work for that. I added a couple of unit tests to assert that settings array is merged correctly.
Comment #6
mradcliffeI guess PHP 5 _is_ still supported technically and the best kind of correct is being technically correct so let's remove the visibility for now until testbot no longer runs PHP 5.
Comment #8
mradcliffeCommitted.