Documenting a chance find. In class UnroutedUrlAssemblerTest function setupRequestStack there is a SERVER_NAME variable that looks to have a wrong value.

'SERVER_NAME' => 'http://www.example.com',

This need to be:

'SERVER_NAME' => 'www.example.com',

I'm not sure if this may cause a test failure if fixed.

CommentFileSizeAuthor
#12 after patch.png150.43 KBanjali rathod
#12 before patch.png192.21 KBanjali rathod
#12 patch apply.png117.45 KBanjali rathod
#11 Issue-2990740-11-by-hass-Wrong-value-in-SERVERNAME-of-U.patch680 bytesAnkit.Gupta
#2 Issue-2990740-by-hass-Wrong-value-in-SERVERNAME-of-U.patch881 byteshass

Comments

hass created an issue. See original summary.

hass’s picture

hass commented
Status: Active » Needs review
StatusFileSize
new Issue-2990740-by-hass-Wrong-value-in-SERVERNAME-of-U.patch881 bytes

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Priority: Normal » Minor
Status: Needs review » Needs work
Issue tags: +Bug Smash Initiative, +Needs reroll, +Novice

Certainly a minor issue, changing priority.

Suitable for a novie task, adding tags.

Ankit.Gupta’s picture

Ankit.Gupta commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new Issue-2990740-11-by-hass-Wrong-value-in-SERVERNAME-of-U.patch680 bytes

Reroll the patch #2 with Drupal 9.5.x

anjali rathod’s picture

anjali rathod
Primary language English
Location India
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new patch apply.png117.45 KB
new before patch.png192.21 KB
new after patch.png150.43 KB

I have applied the patch and tested the site works fine. Attaching the screenshots below for reference.

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs review

@Anjali Rathod, thanks for the interest and confidence that the patch works. Please be aware that screenshots of patches applying are not useful (the testbot will let us know if the patch applies cleanly), nor are screenshots of your IDE. For Drupal core credit is given according to How is credit granted for Drupal core issues which points out that unhelpful screenshot will likely not get credit. There are detailed descriptions of the tasks available when working on Drupal core at Find a task which you may find useful.

@Anjali Rathod, and finally you mention that you tested that patch and have provided screenshots. But what exactly did you do to test the patch?

Setting back to NR for my question above.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Not sure what was tested but this doesn't seem to cause any test failures. So does that mean it wasn't being used right or is just a placeholder value?

Will let the committer decide.

  • catch committed 926297a4 on 10.1.x 
    Issue #2990740 by hass, Ankit.Gupta: Wrong value in SERVER_NAME of...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

It's just to have something to pass to $request->server->add() I think, but makes sense for that to look realistic - could equally wonder why it's missing if we took it out.

Committed 926297a and pushed to 10.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.