As of v3.3, this module failed in two different ways with Webforms-generated forms:

  1. Serialized arrays in the extra column were becoming corrupted because their curly braces were being stripped out by ->prefixTables() before the update query was run. As a result, the db_update expression call with the concatenated string with multiple serialized arrays in it will never work. It requires the serialization to happen after the query has been built (including the prefix check).
  2. All of the webform_component records that matched the component ID (cid) were being overwritten regardless of which webform node ID (nid) it was. It would only work on a site with one webform (and no duplicate cids).

This patch fixes both of these issues.

CommentFileSizeAuthor
#2 file_upload_security-fixes_multiple_webforms_serialized_array_corruption-2990568-1-7.59.patch3.26 KBaubjr_drupal

Comments

aubjr_drupal created an issue. See original summary.

aubjr_drupal’s picture

aubjr_drupal commented
StatusFileSize
new file_upload_security-fixes_multiple_webforms_serialized_array_corruption-2990568-1-7.59.patch3.26 KB

mrdalesmith’s picture

mrdalesmith commented
Status: Needs review » Fixed

Thanks for that: I've pushed to a new release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.