#2986383: Drupal core compatibility: Block content entities have a `reusable` field in 8.7+ fixed a Drupal core compatibility by updating test expectations to include a reusable attribute. This has since been backported to 8.6. We need to update our test expectations to account for that.

CommentFileSizeAuthor
#2 2990552-2.patch524 bytesgabesullice

Comments

gabesullice created an issue. See original summary.

gabesullice’s picture

gabesullice
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 2990552-2.patch524 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 2990552-2.patch, failed testing. View results

  • gabesullice committed db11b77 on 8.x-2.x 
    Issue #2990552 by gabesullice: Followup to #2986383: Custom content...
gabesullice’s picture

gabesullice
Primary language English
commented
Status: Needs work » Fixed

The last failure was due to #2990133: Fix deprecation error in 8.5.x caused by Symfony\Component\HttpKernel\Controller\ControllerResolver::getArguments(), this fixed what it was supposed to fix.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Needs backport to 8.x-1.x, because this change is causing those tests to also fail: https://www.drupal.org/pift-ci-job/1035236. OTOH, perhaps we don't care about the 1.x branch's tests failing against the next core minor, especially for failures like this, where everything actually works just fine, and it's merely expectations that need to be updated?

gabesullice’s picture

gabesullice
Primary language English
commented

I thought about this as well. I wanted to give core a chance to settle a little more so we could bundle any commits like that together into a single "compatibility" release.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Sounds good!

gabesullice’s picture

gabesullice
Primary language English
commented
Assigned: gabesullice » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.