I noticed that when I enter a "via" account name / handle in the config, the resulting tweet include "via @@my_twitter_hande". That should not be double. Basically, the code does not need to supply the @ symbol; Twitter constructs that on its own.
If I do not enter a "via" username, the tweet will include "via @". This is a separate issue, perhaps.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | Screen Shot 2020-05-23 at 10.55.23 AM.png | 1.02 MB | ramya balasubramanian |
| #9 | simple_social_icons-2990361-13142671.patch | 1.58 KB | caspervoogt |
| #2 | simple_social_icons-2990361-12716288.patch | 1.16 KB | caspervoogt |
Comments
Comment #2
caspervoogt commentedComment #3
caspervoogt commentedComment #4
caspervoogt commentedComment #5
caspervoogt commentednew patch coming
Comment #6
caspervoogt commentedComment #7
caspervoogt commentedComment #8
caspervoogt commentedsee patch in comment #9.
Comment #9
caspervoogt commentedRerolled the patch. This takes care of a related issue; when you leave the "via" field blank, the tweet still included "via @". It should leave out "via" entirely if the field is blank.
Comment #10
ramya balasubramanian commentedComment #11
ramya balasubramanian commentedHi @caspervoogt,
I have applied the patch and added the block in content region. After saving this block, all node's pages are blank. And I have checked the error logs, see the below screenshot.
Comment #12
ramya balasubramanian commented@caspervoogt, Apologies, I was bit occupied and I have tested and added my comment but forgot to unassign the ticket. Unassigning this ticket. Please let me know if I am not checking this patch properly.
Comment #13
caspervoogt commentedNo worries. See if https://www.drupal.org/files/issues/2019-06-11/simple_social_icons-29903... works for you. Once we get this tested a bit (maybe by 1 or 2 others) perhaps we can mark this RTBC and get a maintainer to commit this one.
Comment #14
caspervoogt commentedComment #16
shelane