Problem/Motivation

Symfony changed a deprecation message we are skipping. See https://github.com/symfony/symfony/pull/27868

Proposed resolution

Fix the skip list

This patch is not needed by 8.6.x or 8.7.x as they do not trigger this deprecation anymore.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 2990133-2.patch1.54 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2990133-2.patch1.54 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

unless bot says no

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 86ac20b and pushed to 8.5.x. Thanks!

  • alexpott committed 86ac20b on 8.5.x 
    Issue #2990133 by alexpott: Fix deprecation error in 8.5.x caused by...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

Sadly, Examples CI will keep failing until the next release... https://www.drupal.org/pift-ci-job/1032188

I guess I'll switch to 'supported' instead of 'stable.'

gabesullice’s picture

gabesullice
Primary language English
commented

Still failing for JSON API too: https://www.drupal.org/pift-ci-job/1033075

@Mile23, thanks for the tip, I'll update our automated tests as well.

geerlingguy’s picture

geerlingguy commented

I've been hitting this in CI tests on Travis as well (e.g. https://travis-ci.org/geerlingguy/drupal-honeypot/builds/414256012); going to switch to 8.6.x for now to bypass.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.