Minor user interface text correction in BlockContentDeleteForm

This seems like a simplistic way to do it but I don't see a better way. We have two #markup elements rendered next to each other.

Hi @tetranz, Thanks for the patch. Your patch applied successfully. This patch will add the space between two sentences at the custom basic block delete page.

I think adding the trailing space here will make translations more difficult, as they will also need to include the space.

It might be better to override getDescription() instead of buildForm() and add the message there. See e.g. MenuDeleteForm or ImageStyleDeleteForm which have similar logic in their getDescription() methods.

Thanks @longwave. I had a feeling that wasn't the right way to go. I'll look at that in the next few days if nobody else does.

This should be a little better.

I've done it slightly different to those other examples to avoid string concatenation and an unnecessary paragraph when there are no placed instances.

Works as described.

Unrelated fail.

Combining strings like this doesn't work for translating. Sentence order can be complex.

I think we have a couple of possibilities here:
Move the $this->formatPlural(count($instances), 'This will also remove 1 placed block instance.', 'This will also remove @count placed block instances.') into a proper Drupal message ie do:

    if (!empty($instances)) {
      $this->messenger()->addWarning($this->formatPlural(count($instances), 'This will also remove 1 placed block instance.', 'This will also remove @count placed block instances.'));
    }

Or we could do something like

  /**
   * {@inheritdoc}
   */
  public function getDescription() {
    $instances = $this->entity->getInstances();
    if (!empty($instances)) {
      return $this->formatPlural(count($instances), 'This will also remove 1 placed block instance. This action cannot be undone.', 'This will also remove @count placed block instances. This action cannot be undone.');
    }
    return parent::getDescription();
  }

Added a patch with the above mentioned change by #11.

We weren't really combining strings, they were two separate paragraphs and we do the same elsewhere (albeit not with sprintf). Still, #12 is functionally identical so RTBC.

@longwave hmmm good point but I think this is the correct change because the description for the delete form is changing depending on whether additional things are going to be deleted so it makes sense to me.

Committed c0ab589 and pushed to 8.7.x. Thanks!

diff --git a/core/modules/block_content/src/Form/BlockContentDeleteForm.php b/core/modules/block_content/src/Form/BlockContentDeleteForm.php
index 233f3bcb04..3a77b65f65 100755
--- a/core/modules/block_content/src/Form/BlockContentDeleteForm.php
+++ b/core/modules/block_content/src/Form/BlockContentDeleteForm.php
@@ -3,7 +3,6 @@
 namespace Drupal\block_content\Form;
 
 use Drupal\Core\Entity\ContentEntityDeleteForm;
-use Drupal\Core\Form\FormStateInterface;
 
 /**
  * Provides a confirmation form for deleting a custom block entity.

Fixed unused use on commit.

diff --git a/core/modules/block_content/src/Form/BlockContentDeleteForm.php b/core/modules/block_content/src/Form/BlockContentDeleteForm.php
old mode 100644
new mode 100755

The file mode shouldn't be changed by this patch. Fixed on commit.