Consensus On Layouts

Hi serg2,

I agree with moving the layouts to the module and have been developing using the patches without problems. I feel like someone told me recently that layouts are allowed in themes when i was at Design4Drupal, but overall this still would be be the best move for maintaining the theme, and it is legitimate since it is an alpha version theme.

So it seems like the Foundations Layout module is the best place for this to be handled, rather than try to maintain layouts in two places. I also think if we can simplify the base theme enough to make it more easily maintainable, this theme will have a better chance of keeping up with Drupal 8/9's development.

OK... maybe I'm being a bit heavy-handed, and I understand if this gets tossed out immediately, but I'm submitting a patch that (hopefully) removes the layouts from 8.x-6.x. I think this will move us closer to both goals of handling layouts in the other module, and simplifying what needs to happen in this base theme to keep this theme maintainable.

I see now that this patch is pretty much a duplicate of the patch on #2867688: compatibility problem with drupal-8.3.0 and ds-8.x-3.x. So I guess my question is if there's a strong reason to wait on getting this in to 8.x-6.x?

I agree it is the best thing for maintainability and consistency with the rules about layouts to move the layouts to Foundations Layout, but I am wary of posting a breaking change to 8.x-6.x. However we are still in alpha so we are 'allowed' to do so. (I finally closed out a very long project and definitely would like to settle this and, most likely go with your idea)

This is only a breaking change if people are using the layouts feature in the zurb foundation theme, right? I think when I was last testing this they weren't working, so it seems unlikely that people are using them. But maybe they're using past versions and only more recent versions of the theme have them broken.

That's a good point. I pinged the long standing issues that, we should try to finally resolve this this month imo.

I think it is best to move the layouts out into the module, which will simplify maintaining the rest of the theme. If anyone disagrees I hope they can chime in here in the next week or 2.

+1 to move the layouts out, it is always better to separate the fact of being able to use the different functions of foundation and examples of uses of it is functionalities that are in fact optional.

It's a bit like the bar of the head, ok she's cool, but personally I have never used it, the customers always have other needs for their top of page. This may also be able to move with layouts ... I say sometime stupid things ;-), but these an idea.

I might point out here that in our sub-theme we have removed the layouts.yml and have used the xy_grid_layouts module in place as it has a number of beneficial settings when applying the layout (via third party settings). I suggest any implementation should follow the work being done there.

@philosurfer nice I had not seen that one. Good advice. I added a link to the front page of this project to that!

@HongPong Circling back to this issue, it seems like the overall agreement is to move forward with removing layouts from the main theme. What are next steps? Does the patch on this branch cover what we'd want to do? Should the patch on the other issue be re-rolled?

I would like to move forward with this. I think we're in agreement that we can remove layouts. Can someone else test that this patch works for them? In particular, if someone that has an older subtheme, does this break anything? If so, what steps do we need to include in the release notes to help user?

I'd vote on keeping them separate - it allows for a bit more flexibility as there are multiple types of layout in Zurb (or people might just want to do their own using CSS Grids and use the rest of zurb for components etc) as it keeps this side of things nimbler. I used to use Foundation components along with singularity as a grid system for cusstom projetcs as it'd let me have cleaner / more semantic / more maintanable IMO code.

The only headache I'd see coming out of it would be pairing versions of this to the various layout modules, for example the only breaking change for moving from 6.5.3 to 6.6.1 that's of any real impact is the revamping of XY grids... so someone upgrading this would need to pull a new branch of the xy_grids module. That said we're in alpha and things break, and if you put a disclaimer on the project page it seems reasonable to me.

https://github.com/foundation/foundation-sites/releases & https://github.com/foundation/foundation-sites/pull/11405

Ok, I am moving forward from this. I agree with you @erutan, that we can make notes about the potential breaking impact of this change on the release notes and direct people to pull the latest from the xy_grids module.

I've tested this again and it still applies cleanly to the master branch locally for me.

Ok I have committed this fix. Yay! thank you to everyone on this thread and the other thread for working through this big change.