Problem/Motivation

\Drupal\advagg_css_minify\Form\SettingsForm defines an option 'Add licensing comments', which is saved to advagg_css_minify.settings under the key 'add_license'. However, this property is not described in advagg_css_minify.schema.yml, causing a schema error.

Proposed resolution

Add the 'add_license' property to advagg_css_minify.schema.yml

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 advagg-advagg_css_minify_setting_not_defined-2988628-2.patch1.37 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new advagg-advagg_css_minify_setting_not_defined-2988628-2.patch1.37 KB

Attached patch adds the 'add_license' property to advagg_css_minify.schema.yml based on a similar implementation in advagg_js_minify.schema.yml

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs review » Fixed

Thanks for catching that and the patch. Applied.

  • NickWilde committed f95775c on 8.x-3.x authored by idebr 
    Issue #2988628 by idebr: advagg_css_minify.settings.add_license is not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.