Return types for AliasStorageInterface::preloadPathAlias() should match AliasStorage::preloadPathAlias()

I disagree with this, we can also make this constrain to the interface by changing the return FALSE to return [] in the catch. As far as I can see from the current testcoverage there doesn't seem to be anything that actually tests the return false usecase.

So I think we should change to code instead of changing the interface.

I will work on this in ContributionWeekend2019

Here is the patch.

Patch looks fine to me but I am wondering if this will help as with exception, we call $this->catchException($e); and this throws exception (although only when table exists and I think table will be there as we already doing check for the table in the method earlier).

So not sure if we really need to return something here.

I think table will be there as we already doing check for the table in the method earlier

are you sure? it will do check when $select->execute() is called, so it's done in try / catch. That's why we need to return [] when table doesn't exist and trow exception when table exists.

So, patch from #8 looks good for me.

Needs reroll!
Thanks

Patch from #8 cleanly applies to 8.8.x, bumping version

The AliasStorage class has been rewritten to change path storage entirely. It won't ever return FALSE any more.