It is not recommended to use underscore (_) in url. Can you replace underscore (_) with dash (-) in urls
https://magenticians.com/dash-or-underscore-preferred-in-urls/

CommentFileSizeAuthor
#12 private_message-replace_underscore_with_dash_in_url-2988492-12.patch7.55 KBphjou
#8 2988492-8.patch6.36 KBshubham.prakash
#7 interdiff.txt550 bytesphjou
#7 private_message-replace_underscore_with_dash_in_url-2988492-6.patch6.54 KBphjou
#5 private_message-replace_underscore_with_dash_in_url-2988492-5.patch6.01 KBphjou
#2 replace_underscore_with_dash_in_url-2988492-2.patch4.85 KBsergiu stici

Comments

zenimagine created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
StatusFileSize
new replace_underscore_with_dash_in_url-2988492-2.patch4.85 KB
sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
anmolgoyal74’s picture

anmolgoyal74 commented
Status: Needs review » Needs work

You also need to update the paths in configs.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
StatusFileSize
new private_message-replace_underscore_with_dash_in_url-2988492-5.patch6.01 KB

Just updated the block config too.
The patch was not applying anymore probably because of the permission issue we fixed.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
Status: Needs work » Needs review
phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
StatusFileSize
new private_message-replace_underscore_with_dash_in_url-2988492-6.patch6.54 KB
new interdiff.txt550 bytes

Ok just found a little line we missed.

shubham.prakash’s picture

shubham.prakash commented
StatusFileSize
new 2988492-8.patch6.36 KB

The given patch couldn't be applied, so created a new one for the same issue.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented

@shubham.prakash The patch applies well for me, are you on the latest commit of the 8-2.x dev branch? When I look at your patch it seems you're not.

shubham.prakash’s picture

shubham.prakash commented
Status: Needs review » Reviewed & tested by the community

The patch in #7 fixes the issue.

anmolgoyal74’s picture

anmolgoyal74 commented
Status: Reviewed & tested by the community » Needs work

Readme file needs to be updated as well.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new private_message-replace_underscore_with_dash_in_url-2988492-12.patch7.55 KB

Just updated the README file.

  • anmolgoyal74 committed c6ed8e9 on 8.x-2.x authored by phjou 
    Issue #2988492 by phjou, shubham.prakash, Sergiu Stici, anmolgoyal74,...
anmolgoyal74’s picture

anmolgoyal74 commented
Status: Needs review » Fixed

Thanx for the patch.

anmolgoyal74’s picture

anmolgoyal74 commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.