Hi,
These 3 issues with the new JavaScript in this version have been causing me problems as the JavaScript is not valid:

CommentFileSizeAuthor
#9 eu-cookie-compliance-json-has-cannot-be-class-use-let-not-supported-2986882-8-8.x.patch527 bytessvenryen
#3 eu_cookie_compliance-javascript-errors-2986882-3.patch1.31 KBsmokris

Comments

StephenRobinson created an issue. See original summary.

svenryen’s picture

svenryen commented

Thanks, Stephen. I'll see to that it's addressed.

smokris’s picture

smokris
Location Athens, Ohio, USA
commented
Issue summary: View changes
Status: Patch (to be ported) » Needs review
StatusFileSize
new eu_cookie_compliance-javascript-errors-2986882-3.patch1.31 KB

I converted the inline diff from the case body into a patch that applies to 7.x-1.x, attached.

svenryen’s picture

svenryen commented

Thanks, the patch looks good (haven't applied it yet, so keeping this at Needs review)

jyraya’s picture

jyraya commented

For my platform, I need a full compatibility with a wide range of browsers.

I added this patch in my stack and it works without any problem on several browsers installed on Windows or Mac.

svenryen’s picture

svenryen commented
Status: Needs review » Reviewed & tested by the community

Thanks. I'll move it to RTBC since you confirm it works on all browsers. :)

svenryen’s picture

svenryen commented

Port to D8 is needed.

  • svenryen committed 517e9f7 on 7.x-1.x authored by smokris 
    Issue #2986882 by smokris: Key to json hash cannot be "class" as it is a...
svenryen’s picture

svenryen commented
StatusFileSize
new eu-cookie-compliance-json-has-cannot-be-class-use-let-not-supported-2986882-8-8.x.patch527 bytes

Here's the patch for D8. D8 uses addClass for the JS, so only the "let" declaration had to be changed.

  • svenryen committed 4645663 on 8.x-1.x 
    Issue #2986882 by svenryen, smokris: Key to json hash cannot be "class"...
svenryen’s picture

svenryen commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.