This is the JSON API sister issue of #2895532: @DataType=map cannot be normalized, affects @FieldType=link, @FieldType=map.

CommentFileSizeAuthor
#13 2986404-13.patch9.08 KBwim leers
#13 interdiff.txt2.27 KBwim leers
#11 2986404-11.patch10.34 KBwim leers
#11 interdiff-7-11.txt2.13 KBwim leers
#11 interdiff.txt2.27 KBwim leers
#9 2986404-9.patch10.12 KBwim leers
#9 interdiff.txt1.91 KBwim leers
#7 2986404-7.patch8.91 KBwim leers
#7 interdiff.txt2.46 KBwim leers
#6 2986404-6.patch8.34 KBwim leers
#6 interdiff.txt1.81 KBwim leers
#4 2986404-4.patch6.58 KBwim leers
#4 interdiff.txt622 byteswim leers
#2 2986404-2-do-not-test.patch6.59 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Postponed
StatusFileSize
new 2986404-2-do-not-test.patch6.59 KB

This is blocked on #2895532-162: @DataType=map cannot be normalized, affects @FieldType=link, @FieldType=map getting committed to Drupal core.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Postponed » Active
Issue tags: -Needs upstream bugfix

#2895532: @DataType=map cannot be normalized, affects @FieldType=link, @FieldType=map landed! I'll work on this later today.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Category: Feature request » Task
Status: Active » Needs review
StatusFileSize
new interdiff.txt622 bytes
new 2986404-4.patch6.58 KB

This was only blocked on #2895532: @DataType=map cannot be normalized, affects @FieldType=link, @FieldType=map to ensure JSON API implements the exact same solution.

Also, this is hardly a feature request. Somewhere between a bug and a feature. Let's settle on Task.

#2 still applies cleanly. I ported over all relevant interdiff changes between #2895532-162: @DataType=map cannot be normalized, affects @FieldType=link, @FieldType=map and #2895532-179: @DataType=map cannot be normalized, affects @FieldType=link, @FieldType=map (the committed patch). Let's see how this does.

Status: Needs review » Needs work

The last submitted patch, 4: 2986404-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.81 KB
new 2986404-6.patch8.34 KB

Apparently there's a bug in ::testPatchIndividual(). It needs an improvement that ::testPostIndividual() already has!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new interdiff.txt2.46 KB
new 2986404-7.patch8.91 KB

Let's make ::testPatchIndividual() follow ::testPostIndividual()'s lead more closely.

Status: Needs review » Needs work

The last submitted patch, 7: 2986404-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.91 KB
new 2986404-9.patch10.12 KB

The test entity type doesn't exist on 8.5. D'oh. Updated accordingly.

Status: Needs review » Needs work

The last submitted patch, 9: 2986404-9.patch, failed testing. View results

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt2.27 KB
new interdiff-7-11.txt2.13 KB
new 2986404-11.patch10.34 KB

😅

Status: Needs review » Needs work

The last submitted patch, 11: 2986404-11.patch, failed testing. View results

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt2.27 KB
new 2986404-13.patch9.08 KB

Ugh, it fails even during ::setUp(). I gave up, and ran tests on Drupal 8.5 locally. Found a much simpler solution.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned

Passed on 8.5, 8.6, 8.7! 🎉

gabesullice’s picture

gabesullice
Primary language English
commented
Status: Needs review » Reviewed & tested by the community 
+++ b/tests/src/Functional/EntityTestMapFieldTest.php
@@ -10,6 +10,9 @@ use Drupal\user\Entity\User;
+ * @requires function Drupal\entity_test\Entity\EntityTestMapField::baseFieldDefinitions

oooh, that's fancy.

Good work 👏

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

It's fancy and also the only way I could make it work — an if-test + $this->markTestSkipped() didn't work, I tried that first 😅

  • Wim Leers committed 951cd01 on 8.x-2.x 
    Issue #2986404 by Wim Leers: @FieldType=map support
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.