Change record: JavascriptTestBase is deprecated in favor of WebDriverTestBase.

CommentFileSizeAuthor
#5 2986222-5--switch_to_WebDriverTestBase.patch8.77 KBdrunken monkey
#5 2986222-5--switch_to_WebDriverTestBase--interdiff.txt4.56 KBdrunken monkey
#3 2986222-3--switch_to_WebDriverTestBase.patch4.21 KBdrunken monkey
#3 2986222-3--switch_to_WebDriverTestBase--interdiff.txt2.07 KBdrunken monkey
#2 search_api-switch_to_webdrivertestbase-2986222-2.patch3.7 KBidebr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drunken monkey created an issue. See original summary.

idebr’s picture

idebr CreditAttribution: idebr at ezCompany commented
Status: Active » Needs review
FileSize
search_api-switch_to_webdrivertestbase-2986222-2.patch3.7 KB

Attached patch switches JavascriptTestBase to WebDriverTestBase.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
FileSize
2986222-3--switch_to_WebDriverTestBase--interdiff.txt2.07 KB
2986222-3--switch_to_WebDriverTestBase.patch4.21 KB

Oh, thanks a lot! Looks pretty good, and test bot is happy, too – excellent!

+++ b/tests/src/FunctionalJavascript/AjaxTest.php
@@ -106,7 +106,7 @@ class AjaxTest extends JavascriptTestBase {
     $this->drupalGet('admin/config/search/search-api/add-index');
-    $assert_session->pageTextContains('Datasources');
+    $assert_session->pageTextContains('Data sources');
     $assert_session->pageTextContains('Content');

This is a bit disturbing, though. How did this even pass before?
Anyways, as we generally use “datasource” (no space) throughout the module, the correct fix here is to change the form definition, I’d say. (Even though, apparently, this makes that assertion less reliable.)

Patch attached, feedback welcome!

Status: Needs review » Needs work

The last submitted patch, 3: 2986222-3--switch_to_WebDriverTestBase.patch, failed testing. View results

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Needs work » Needs review
FileSize
2986222-5--switch_to_WebDriverTestBase--interdiff.txt4.56 KB
2986222-5--switch_to_WebDriverTestBase.patch8.77 KB

Ah, what the heck, then let’s just correct all of them …

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Needs review » Postponed
Issue tags: +Drupal 8.6 dependency

  • drunken monkey committed 12015c5 on 8.x-1.x authored by idebr 
    Issue #2986222 by idebr, drunken monkey: Switched Javascript tests to...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Postponed » Fixed

Just re-ran the tests and this still works. So: committed.
Thanks a lot again, idebr!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.