It appears some update tests were added after #2870009: Update: Convert system functional tests to phpunit landed or we just plain missed them for some reason.

todo:
Covert remaining update tests extending \Drupal\system\Tests\Update\UpdatePathTestBase

CommentFileSizeAuthor
#2 2985734-2.patch5.52 KBlendude

Comments

Lendude created an issue. See original summary.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Active » Needs review
Parent issue: » #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase)
StatusFileSize
new 2985734-2.patch5.52 KB

Here we go. Lets see what this does.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

I think this is a good improvement, I had one remark on this patch, but it's not worth setting this back to NW over it.

+++ b/core/modules/rest/tests/fixtures/update/rest-export-with-authentication-correction.php
@@ -2,7 +2,7 @@
- * Test fixture for \Drupal\rest\Tests\Update\RestExportAuthCorrectionUpdateTest.
+ * Test fixture for \Drupal\Tests\rest\Functional\Update\RestExportAuthCorrectionUpdateTest.

Do we need the class name in here? Because the class name here doesn't make it reusable and prone to get outdated.

It is just a test conversion, so we probably shouldn't do that in this issue. We could open a followup to do that?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed eb5d499d31 to 8.7.x and 9a2592f7ed to 8.6.x. Thanks!

re #3 - I'm not sure it matters. Tests don't move often.

  • alexpott committed eb5d499 on 8.7.x 
    Issue #2985734 by Lendude: Convert remaining update tests extending...

  • alexpott committed 9a2592f on 8.6.x 
    Issue #2985734 by Lendude: Convert remaining update tests extending...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.