Now that Drupal core 7.x passes tests with PHP 7.2, we can see what remains to be done in Ubercart.

I triggered PHP 7.2 tests for Ubercart (see https://www.drupal.org/pift-ci-job/1008781) and it appears that only one line of code is a problem - here's a patch to fix that. Let's see if this makes our 7.2 tests run green:

CommentFileSizeAuthor
php-7-2.patch721 bytestr

Comments

TR created an issue. See original summary.

  • TR committed 83760f8 on 7.x-3.x 
    Issue #2985692 by TR: Support PHP 7.2, now that core Drupal does
tr’s picture

tr commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

daften’s picture

daften commented

Can a new release be made with this included?

erykolryko’s picture

erykolryko commented

.

mr.white’s picture

mr.white commented

+1

axle_foley00’s picture

axle_foley00 commented

+1. I agree it would be good to have an official release for this.

hossein425’s picture

hossein425 commented
Version: 7.x-3.x-dev » 7.x-3.11

The patch is not applied to the latest release version, 7.x-3.11

tr’s picture

tr commented
Version: 7.x-3.11 » 7.x-3.x-dev

The patch was committed to the code base on 13 July 2018, as you can see above. Releases of Ubercart which already existed at that time cannot be changed. New releases of Ubercart made after that time will automatically include the patch. That's how all of Drupal works.

hossein425’s picture

hossein425 commented

Thanks for clarification, I read the release date as Feb 2019!