After updating the module, a warning message appears about undefined withdraw_message, consent_storage_method and disabled_javascripts indexes

Thank you for the patch. It addresses the issue, but not in the way I would like it addressed.

The problem was that variables are not set per language. So instead of checking isset(), we should make an update hook and populate the proper default in the database. Also, users of Domain Access will have problems, since defaults are not being set per domain either.

Your patch should be a good remedy meanwhile. You can also fix this problem by saving the settings form for each language.

Hello,

I am meeting the same issue. I worked on the hook_update in order to set parameters of 'eu_cookie_compliance' with default values when they are not defined.
I preferred defining a new hook_update that treats the 'eu_cookie_compliance' variable and its translations because the first update hook that migrated variable values is present since a long time. I nevertheless corrected it to use i18n_variable_set which is more appropriate and to simplify the module enabling control as "i18n_variable" is dependent of "variable_realm".

I kept the content of the jasa's path because it is aligned with what it is implemented elsewhere for mandatory parameters.
For instance, 'popup_agree_button_message' is required but nevertheless there is a isset control on the default value setting.

@svenryen, let me know if that is aligned with what you have in mind.

Hi!

In addition to this, we have problems with defaults for people who use domain access (and possibly combinations of i18n and domain access).
Would you be able to test the code and see that it also sets defaults in those cases?

I will do.

I have some problems to install locally an environment to test domain_access.
I hope to come back with news soon.

#5 works fine (simple site without domain_access)

Confirming patch from #5 fixing the issue just fine (on a rather simple site without domain_access).

The patch still must be pushed. So, the issue cannot be considered as fixed.

@svenryen,

I did not have the opportunity to test the combination of domain_access and i18n butI am still wondering if the problem you are talking about is really linked to the current issue.

Here, we cover 2 cases:

• A fresh module install where by definition no setting translation has been done yet .
• A module update where the domain_access settings were no translatable before.

So, could we not achieve this issue and leave the domain access issue fixed via the #2978792: Settings not saved using Domain Access + i18n.

In the meantime, I set the issue in RTBC.

Thanks for reviewing the issue.

Hi,
After update to 7.x-1.x-dev of EU Cookie Compliance module to resolve the consent_storage_method and disabled_javascripts indexes error, i got another error : Fatal error: Using $this when not in object context in /sites/all/modules/eu_cookie_compliance/eu_cookie_compliance.admin.inc on line 136
Have you got any idea ?
Thanks.

Hello navalogan,

I switch the status back to "fixed" because it is related to another commit and it is treated in #3008905: Error: Using $this when not in object context where I pushed a patch if you want to test it.

Regards.