The default settings (such as "method: default") are not set for multilingual sites. As a consequence, all multilingual sites that updated to 1.24 will switch to "opt in" mode.

We need a new update hook where the appropriate defaults are set for each of the languages configured.

Comments

svenryen created an issue. See original summary.

svenryen’s picture

Possibly they also need to be set for any domains set by the domain access module.

svenryen’s picture

When going from v 1.23 to the current, we don't set all the defaults as new variables are added to the module.

In version 7.x-1.26, we missed setting the defaults for "disagree_button_label", "method" and "whitelisted_cookies" in the translated configuration.

Domain access config updates are in a terrible state. We fail to set every single new default config variable, and as a result, if you upgrade from 7.x-1.0 (or any other old version) with domain_settings enabled, the config will lack defaults for 48 variables.

25 variables lack defaults for the un-translated settings (when going from 1.0 to 1.29) and 28 are missing from the translated config until you save the module configuration.

We should add all the missing defaults to the settings in a new hook, and also adopt a standard procedure for adding new configuration to the update hooks (covering both domain_settings and i18n_variable).

svenryen’s picture

Here's a patch that properly adds all missing variables when updating.

  • svenryen authored 52ba1e1 on 7.x-1.x
    Issue #2985438 by svenryen: When upgrading, newly introduced default...
svenryen’s picture

Status: Active » Fixed
svenryen’s picture

Here's an additional patch. I realized after a night's sleep that the logic was flawed. Here's one that's tested. You need to apply both patches for this issue.

  • svenryen authored a29c465 on 7.x-1.x
    Issue #2985438 by svenryen: When upgrading, newly introduced default...

  • svenryen authored 52ba1e1 on 7.x-2.x
    Issue #2985438 by svenryen: When upgrading, newly introduced default...
  • svenryen authored a29c465 on 7.x-2.x
    Issue #2985438 by svenryen: When upgrading, newly introduced default...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.