Closed (fixed)
Project:
EU Cookie Compliance (GDPR Compliance)
Version:
7.x-1.24
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Jul 2018 at 20:04 UTC
Updated:
4 Aug 2019 at 17:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
svenryen commentedPossibly they also need to be set for any domains set by the domain access module.
Comment #3
svenryen commentedWhen going from v 1.23 to the current, we don't set all the defaults as new variables are added to the module.
In version 7.x-1.26, we missed setting the defaults for "disagree_button_label", "method" and "whitelisted_cookies" in the translated configuration.
Domain access config updates are in a terrible state. We fail to set every single new default config variable, and as a result, if you upgrade from 7.x-1.0 (or any other old version) with domain_settings enabled, the config will lack defaults for 48 variables.
25 variables lack defaults for the un-translated settings (when going from 1.0 to 1.29) and 28 are missing from the translated config until you save the module configuration.
We should add all the missing defaults to the settings in a new hook, and also adopt a standard procedure for adding new configuration to the update hooks (covering both domain_settings and i18n_variable).
Comment #4
svenryen commentedHere's a patch that properly adds all missing variables when updating.
Comment #6
svenryen commentedComment #7
svenryen commentedHere's an additional patch. I realized after a night's sleep that the logic was flawed. Here's one that's tested. You need to apply both patches for this issue.