Closed (fixed)
Project:
Views Bulk Operations (VBO)
Version:
4.4.x-dev
Component:
Actions
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
12 Jul 2018 at 16:54 UTC
Updated:
31 Oct 2025 at 13:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
dave reidComment #3
dave reidMessage needs tweaking.
Comment #4
graber commentedHi, thanks for your work on the subject @Dave Reid.
2 things:
Comment #5
balintbrewsI rerolled the patch for 8.x-3.x-dev and made the requested changes.
Comment #6
graber commentedNice, but this should be configurable in the View admin (see
ViewsBulkOperationsPreconfigurationInterface), imagine someone deleting 100 000 entities in a bulk operation and getting this many log entries..Comment #10
peachez commentedAdding Reroll patch for 4.3.x
I dont seem to be able to push to push to issue fork. Im sure im doing it wrong :P
Comment #11
malcomio commentedComment #15
graber commentedLeft a review, also please make sure all checks are green.
Comment #16
graber commentedOk, I left the review on https://git.drupalcode.org/project/views_bulk_operations/-/merge_request... but it also applies to the latest branch.
Comment #17
malcomio commentedI've taken the patch from #10 and put it into https://git.drupalcode.org/project/views_bulk_operations/-/merge_request...
Comment #18
graber commentedGreat but please see my notes on the other MR that also apply.
Comment #19
malcomio commentedComment #20
graber commentedThank you, Looks good!
I have one more concern: what if someone deletes a lot of entities - do we still want to log all that? I think we may leave it as is for the time being though and if someone's log will be flooded and they don't like that they can always create a follow-up to make it configurable.
I'll let it lay for a week or so in case someone else had any feedback.
Comment #21
malcomio commentedThanks - that sounds like a good way forward.
If we do make it configurable, I'd suggest that the default is that logging is enabled.
I was surprised when I realised that nodes deleted this way weren't logged - I'd say it's better to be consistent with core, which does log individual node deletion.
Comment #22
graber commentedComment #25
graber commented