The position of the toolbar moves above the off-canvas top dialog if a modal dialog is opened

I noticed this issue, which lead me to open #2983120: OffCanvas dialog doesn't close when opening a standard Dialog.

Re-rolled the patch. Please review.

Issue summary needs to be updated with proposed solution (if still an issue)

Also #2 still cleanly applied to 11.x.

It's definitely still an issue, I just closed #3152830: After closing workspaces dialog the vertical admin toolbar is displayed on top of workspaces interface as a duplicate of this one.

This is still happening after the patch #2, as well. please see screenshot for reference

Earlier, `settings.drupalOffCanvasPosition` was undefined on the second dialog open. I have updated it. However, it is still calculating the height of the off-canvas incorrectly, which needs to be fixed. I am leaving this to NW.

I have added after merge request screenrecording for reference, please review

I've tested MR 8330 On Drupal 11.x
MR is applied cleanly

The toolbar position issue is resolved; however, if the off-canvas is closed using the cross icon, the toolbar position remains unchanged and the page scrolls to the top.
Adding Screen recording for reference

Also as per issue Summary MR is "Open failed pipeline"

Moving to "Needs work"

this commit fixes the problem mentioned in #23.

I've tested Updated MR 8330 On Drupal 11.x
MR is applied cleanly

"The off-canvas is closed using the cross icon, the toolbar position remains unchanged and the page scrolls to the top" issue resolved.
Adding Screen recording for reference

RTBC+1

Not sure this one that can get tests or is large enough for them so will remove that tag, any disagrees please add back.

Will tag for an after screenshot to be added though

With open dialog

Closed dialog

screenshots should be part of the summary.

The current MR seems like quite a bit of height-calculating logic with several new mutable variables in play. I wonder if this can be done simpler.

The toolbar moves because of the margin reset in toolbar.js

if (toolbarBar) {
            toolbarBar.style.marginTop = '0';

// etc...

Perhaps a solution that doesn't apply the reset when a top off-canvas exists would take care of it?

if (toolbarBar) {
           if (<NO TOP OFF-CANVAS>) {
              toolbarBar.style.marginTop = '0';

}
// etc...

This would also be reasonably easy to add as a test inside \Drupal\Tests\system\FunctionalJavascript\OffCanvasTest, and the toolbar doesn't even have to be present - just an element with the id toolbar-bar that you can check the margin-top of.

The if condition that i added is just opposite of what's mentioned in #31 but still it work.I will try to deep dive more into that.

@bnjmnm wonder your thoughts on the current MR?

Could an after screenshot be added?

This isn't quite what I suggested in #31. Left a comment in the MR

Also will need tests - #31 also has an approach to how.