Hops is a starter theme focused on fast coding with sass and gulp.
Hops purpose is to :

  • provide a solid basis to be quickly effective and start coding a fully customized theme fast.
  • provide minimal & documented sass settings, variables and helpers for breakpoints, fonts, colors, layout, etc.
  • provide a component library for styleguide driven development.
  • provide the proper structure to follow Drupal guidelines on css architecture.
  • avoid overly complicated structure, installation process and development flow.
  • avoid forgotten unstyled components by providing a default styling for them.
  • encourage BEM methodology, ui patterns module usage, breakpoints module usage.

Project link

https://www.drupal.org/project/hops

Git instructions

git clone --branch 8.x-1.x https://git.drupal.org/project/hops.git

CommentFileSizeAuthor
#4 Drupal_standard.jpg346.48 KBArvindV

Comments

Raphael Larrinaga created an issue. See original summary.

Raphael Larrinaga’s picture

Raphael Larrinaga commented
Issue summary: View changes
manish34jain’s picture

manish34jain commented

Hello Raphael ,

Please run automated review and check the errors.

Here is the report. https://pareview.sh/pareview/https-git.drupal.org-project-hops.git

Thanks

ArvindV’s picture

ArvindV commented
StatusFileSize
new Drupal_standard.jpg346.48 KB

Hello Raphael Larrinaga

I installed the theme on https://simplytest.me/.

After that first time I click on the settings icon on theme then I am getting website encountered an error message.

Please check the attached screenshot of error log.

Thanks

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes

I fixed the Git instructions: The protocol to use is https://, not git@.

Raphael Larrinaga’s picture

Raphael Larrinaga commented

Thank you all for your feed back.

ESLint is still complaining for gulpfile.js but the file passes all tests locally with latest .eslintrc.json files that comes with Drupal 8.5.5. https://pareview.sh/pareview/https-git.drupal.org-project-hops.git

The error spotted by Arvind_R is solved too.
I suppose a previous state of the theme is cached by https://simplytest.me/ so you will still get the error for the moment.

zymphonies-dev’s picture

zymphonies-dev commented

There are repeated logo images in your theme folder .png and svg format. Please keep single logo.

Raphael Larrinaga’s picture

Raphael Larrinaga commented

Indeed, logo.png was not used anymore. Thank you.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Normal » Critical

To the reviewers: Please set the priority to Normal after reviewing the project.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Priority: Critical » Normal
Status: Needs review » Reviewed & tested by the community

The only error PAReview returns is the following one, which is not an application stopper.

gulpfile.js: line 94, col 7, Error - Parsing error: Unexpected token

I checked the code and I didn't find any security issue. I will approve this application this evening.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Raphael Larrinaga’s picture

Raphael Larrinaga commented

Thank you for the review and the docs!

Note that last error on gulpfile.js has been fixed.
PAReview doesn't spot anything now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Raphael Larrinaga’s picture

Raphael Larrinaga commented

I can't opt into security advisory coverage.
If somebody has the time to check for this… Thank you all.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Try now. It seems I had a problem with my browser when I approved this application.

Raphael Larrinaga’s picture

Raphael Larrinaga commented

This is ok now, thank you.