Style error information

https://eslint.org/docs/rules/function-paren-newline

How to Review

## 1. Apply Patch
## 2. Review Code Changes
## 3. Confirm no Code Standard Errors
yarn & yarn lint:core-js-passing
## 4.1 If `NO` errors, mark the issue as `Reviewed & tested by the community` (Don't be shy, we're all friendly)
## 4.2 If `HAS` errors, fix it and upload a new patch (Just do it and you can!!!)

Background

- #2912962: Step 1 JS codestyle: [meta] Fix JS coding standards in core

- We adapted the airbnb coding standard (#2815077: Adopt airbnb javascript style guide v14.1 as new baseline javascript coding standards for Drupal 8 core and contrib), but we are not fully compliant to it yet.

More Information

- Using ES6 in Core
https://www.drupal.org/node/2815083

- To find JS code standard errors stats
cd core/ && yarn & yarn lint:core-js-stats

Valuable Follow-up

- N/A

CommentFileSizeAuthor
#5 interdiff.txt1.38 KBm1r1k
#5 drupal-js-eslint-function-paren-newline-2983375-5.patch6.06 KBm1r1k
#2 2983375-2.patch6.12 KBApacheEx

Comments

drpal created an issue. See original summary.

ApacheEx’s picture

ApacheEx commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2983375-2.patch6.12 KB

Here is a patch. I have also run yarn run build:js.

m1r1k’s picture

m1r1k commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Crediting @drpal for issue management.


/Volumes/devdisk/dev/drupal/core/misc/vertical-tabs.es6.js
  275:1  error  Expected indentation of 10 spaces but found 8  indent
  276:1  error  Expected indentation of 10 spaces but found 8  indent

/Volumes/devdisk/dev/drupal/core/modules/field_ui/field_ui.es6.js
  27:1  error  Expected indentation of 10 spaces but found 8  indent

✖ 3 problems (3 errors, 0 warnings)
  3 errors, 0 warnings potentially fixable with the `--fix` option.

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

So new things to fix.

m1r1k’s picture

m1r1k commented
Status: Needs work » Needs review
StatusFileSize
new drupal-js-eslint-function-paren-newline-2983375-5.patch6.06 KB
new interdiff.txt1.38 KB
anmolgoyal74’s picture

anmolgoyal74 commented
Status: Needs review » Reviewed & tested by the community

Patch applied successfully and all the changes defined in #4 are implemented in #5.
Marking it RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed e4b5fe2 and pushed to 8.6.x. Thanks!

  • alexpott committed e4b5fe2 on 8.6.x 
    Issue #2983375 by m1r1k, ApacheEx, drpal: JS codestyle: function-paren-...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.