Closed (fixed)
Project:
Commerce Demo
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
27 Jun 2018 at 11:34 UTC
Updated:
21 Aug 2018 at 13:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mglamanComment #3
czigor commentedAdded 5 promotions and one coupon to each. We display a message on
product/123about which coupons can be used in relation to that product.Comment #4
czigor commentedThat's going to be better.
Comment #5
mglamanWe could just target commerce_demo_commerce_product_view to remove one entity type check
Let's just do $messenger = ... once and invoke that
We should probably target the UUID here, since the UUID in our export persists.
And I'm pretty sure that our conditions target UUIDs.
There's a chance someone may have made a product before importing? Maybe?
Comment #6
czigor commentedFixed all the things as all the things made sense.
Comment #7
mglamanWrapping this up.
The patch dies if commerce_promotion is not enabled.
We need to also target `physical`
Comment #8
mglamanThis fixes install. Discussed w/ czigor and it would be good to add some kind of messaging in the checkout as well. I forgot what coupon codes I could use by the time I hit checkout.
Comment #9
mglamanThis is configured wrong and is currently acting as a B1G1
Comment #10
mglamanOkay, here is the patch I'm preparing to commit.
The checkout shows available coupons that can be used for the order
And viewing a product shows a message
Comment #11
mglamanCopy paste fail, times two.
I had exported coupon changes and found them lost. Manually replaced and fixed this without manually testing the export, again. 🤦🤦
Comment #12
mglamanUpdated patch.
Comment #13
mglamanSlightly concerned here we're overwriting a parameter.
Comment #14
mglamanOkay, here we go!
Comment #15
mglamanHere's some more tweaks. Missed the promotion_id back reference in the export. Also B1G2 to B1G1
Comment #16
mglamanDiscussed with rszrama, and we want to make the demo coupon text on checkout more obvious that it's part of the demo.
Comment #17
mglamanExample:
Comment #19
mglaman\o/ landed.