Problem/Motivation

\Drupal\system\Tests\Entity\EntityCacheTagsTestBase is deprecated but there is no trigger error. It is also referenced incorrectly in its replacement \Drupal\Tests\system\Functional\Entity\EntityCacheTagsTestBase

Proposed resolution

Fix this. Re-use the CR https://www.drupal.org/node/2946549 since it is very closely related.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 2981556-2.patch2.22 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2981556-2.patch2.22 KB

We also need to file an issue to properly deprecate \Drupal\system\Tests\Cache\PageCacheTagsTestBase and fix tests extending from it but that is blocked by the conversion of user tests to PHPunit.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Yeah, we don't need to do #2 at the same time, looks very good.

  • catch committed 5e4ce07 on 8.6.x 
    Issue #2981556 by alexpott: Properly deprecate EntityCacheTagsTestBase...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 5e4ce07 and pushed to 8.6.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.